! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[Enhancement] Option to disable Imgur functionality in configuration
Status:
RESOLVED: MOVED
Product:
Xfce4-screenshooter
Component:
General

Comments

Description mgruber_72 2020-02-02 14:43:59 CET
It has happened more than once to me that I accidentally chose Imgur though I'd never use it.
Luckily I always noticed it and were able to cancel or delete it, but there are others which ran into the same situation.
Hence it would be a nice idea, if the whole Imgur functionality could be disabled by a simple switch in a configuration file (should be quite easy to implement) or in the GUI itself.

See also this discussion:
http://forum.xfce.org/viewtopic.php?id=13730
Comment 1 ema-pe 2020-02-05 13:47:55 CET
Created attachment 9427 
Add "Enable Imgur upload" option

Hi,

I created a simply patch that adds an option "enable_imgur_upload". This option is true by default, but you can change it on the configuration file or in the region selection dialog. If it is true, on the action selection dialog the "Host on Imgur" checkbox is insensitive, it is grayed out.

This is my configuration file, for example:

[emanuele@toolbox xfce4-screenshooter]$ cat ~/.config/xfce4/xfce4-screenshooter 
app=none
last_user=
screenshot_dir=file:/home/emanuele/Downloads
action=1
delay=0
region=1
show_mouse=1
enable_imgur_upload=true

I attached some screenshots where you can see the results.
Comment 2 ema-pe 2020-02-05 13:51:47 CET
Created attachment 9428 
Region dialog when "Enable Imgur upload" is true
Comment 3 ema-pe 2020-02-05 13:53:33 CET
Created attachment 9429 
Action dialog when "Enable Imgur upload" is true
Comment 4 ema-pe 2020-02-05 13:55:51 CET
Created attachment 9430 
Region dialog when "Enable Imgur upload" is false
Comment 5 ema-pe 2020-02-05 13:58:33 CET
Created attachment 9431 
Action dialog when "Enable Imgur upload" is false
Comment 6 Git Bot editbugs 2020-05-24 23:58:47 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/xfce4-screenshooter/-/issues/20.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #16420

Reported by:
mgruber_72
Reported on: 2020-02-02
Last modified on: 2020-05-24

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Attachments

Additional information