! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Crash when closing transient window with CSD


Description Theo Linkspfeifer editbugs 2020-01-16 12:01:54 CET
Created attachment 9386 

The following steps trigger a crash of xfwm4:

1. Disable compositing and restart the Xfce session
2. Launch Catfish 1.4.13 and open either the About or Preferences dialog
3. Close the dialog window

This bug does not occur when the compositor is enabled, or when a different window manager like openbox is used. Personally, I have only tested via VirtualBox, but the crash was confirmed to happen on hardware also.

Xubuntu 20.04 (dev release)
Comment 1 Olivier Fourdan editbugs 2020-04-12 17:43:50 CEST
Does it still happen?

Can you please provide:

1. the exact version of xfwm4
2. the exact error message as printed in the log
3. if possible, capture the backtrace when running with GDK_SYNCHRONIZE=1
Comment 2 Yousuf 'Jay' Philips 2020-04-13 18:11:02 CEST
I can confirm it happenes, but catfish isn't running in CSD by default, so are we sure this is a CSD issue.

1. 4.14.0 (revision ed87ef663)
2. this is from syslog

Apr 13 11:44:38 jayx20-virtual-machine dbus-daemon[692]: [system] Activating via systemd: service name='org.freedesktop.hostname1' unit='dbus-org.freedesktop.hostname1.service' requested by ':1.94' (uid=1000 pid=2115 comm="/usr/bin/python3 /usr/bin/catfish " label="unconfined")
Apr 13 11:44:38 jayx20-virtual-machine systemd[1]: Starting Hostname Service...
Apr 13 11:44:38 jayx20-virtual-machine dbus-daemon[692]: [system] Successfully activated service 'org.freedesktop.hostname1'
Apr 13 11:44:38 jayx20-virtual-machine systemd[1]: Started Hostname Service.
Apr 13 11:44:43 jayx20-virtual-machine kernel: [  855.487786] traps: xfwm4[2010] trap int3 ip:7f4f3c5e20d5 sp:7fffebb78e30 error:0 in libglib-2.0.so.0.6400.1[7f4f3c5a6000+84000]

here is the log from the terminal - https://imgur.com/eEReH7M.png
Comment 3 Olivier Fourdan editbugs 2020-04-13 18:27:33 CEST
Thanks, request code 130, minor code 3 → XShape combine
Comment 4 Git Bot editbugs 2020-04-13 18:30:34 CEST
Olivier Fourdan referenced this bugreport in commit ad33f686d645a89b6894e2abd9f3c2b6edf67301

frame: Protect XShape requests

Comment 5 Olivier Fourdan editbugs 2020-04-13 18:31:12 CEST
Can you please try with this fix?
Comment 6 Yousuf 'Jay' Philips 2020-04-13 19:26:51 CEST
Recorded the crash on launchpad, if further digging is required.
Comment 7 Olivier Fourdan editbugs 2020-04-13 19:30:42 CEST
I am not using Ubuntu, I'd be more interested in knowing if the patch fixes the issue...
Comment 8 Theo Linkspfeifer editbugs 2020-04-18 20:22:47 CEST
The patch fixes the issue. Thanks.
Comment 9 Olivier Fourdan editbugs 2020-04-18 20:47:17 CEST
Very cool, thanks!
Comment 10 Git Bot editbugs 2020-05-01 17:46:59 CEST
Olivier Fourdan referenced this bugreport in commit 4925f82ac8bced36213aa5e236d6fbc0b95964ac

frame: Protect XShape requests


Bug #16383

Reported by:
Theo Linkspfeifer
Reported on: 2020-01-16
Last modified on: 2020-05-01


Olivier Fourdan
CC List:
1 user




backtrace (22.18 KB, text/plain)
2020-01-16 12:01 CET , Theo Linkspfeifer
no flags

Additional information