! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Breaks key shortcuts involving media keys
Status:
RESOLVED: MOVED
Product:
Xfce4-pulseaudio-plugin
Component:
General

Comments

Description Stéphane Gourichon 2020-01-10 13:36:56 CET
Opened after discussion on IRC on 2019-01-09 around 16:45 UTC and again on 2019-01-10 around 11:00 UTC. Thanks for the hints helping to understand what happens!

## Overview

Xfce4-pulseaudio-plugin "hides" media keys from xfsettingsd, silently preventing to use key shortcuts involving media keys.

## How to reproduce

* Launch xfce4-keyboard-settings

Control experiment:

* in the "keyboards shortcuts" define a combination that runs "xmessage foo" attached to a regular key combination, like Ctrl-Alt-Shift-H.
* press Ctrl-Alt-Shift-H, see the xmessage window "foo"

Bug-reproducing experiment:

* in the "keyboards shortcuts" define a combination that runs "xmessage foo" attached to a media key, like Play Stop PlayPause Next Previous .
* press the media key

Actual Results: no xmessage window "foo"

Expected Results: see the xmessage window "foo"


## Additional information 

* Observed in Xubuntu 19.10 with default configuration; xfce 4.14.
* Removing xfce4-pulseaudio-plugin from panel allows to get expected behavior, but at the cost of losing all the plugin features.
* In plugin preferences, disabling "Enable multimedia keys for playback control" works around the bug, but at the cost of losing the features.

## What is the core of the bug?

* Violation of the Principle of Least Surprise ( https://en.wikipedia.org/wiki/Principle_of_least_astonishment ) because xfce4-keyboard-settings allows to define shortcut but they don't actually work.

## How could it be fixed?

Suggested behavior: when "Enable multimedia keys for playback control" is active, xfce4-pulseaudio-plugin would handle the shortcut then pass it on so that xfsettingsd can see if there is an additional user-defined shortcut and run it.
Comment 1 Stéphane Gourichon 2020-01-10 13:38:30 CET
This commit https://git.xfce.org/panel-plugins/xfce4-pulseaudio-plugin/commit/?id=3892875b8dceb65ddfcad4091a95cd22725d4cc7 added support for the media keys, most probably creating the bug, and the workarounds mentioned in the description, at the same time.
Comment 2 Git Bot editbugs 2020-05-23 00:41:02 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/panel-plugins/xfce4-pulseaudio-plugin/-/issues/31.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #16363

Reported by:
Stéphane Gourichon
Reported on: 2020-01-10
Last modified on: 2020-05-23

People

Assignee:
Andrzej
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information