! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Replace deprecated G_FILE_MONITOR_EVENT_MOVED
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Theo Linkspfeifer editbugs 2020-01-07 12:01:05 CET
Same as bug 16328, but for xfdesktop.
Comment 1 Git Bot editbugs 2020-01-09 04:43:01 CET
Andre Miranda referenced this bugreport in commit 00c5f70a943194c36f73cc15b93ded7d2ac7c71b

Replace deprecated G_FILE_MONITOR_EVENT_MOVED (Bug #16342)

https://git.xfce.org/xfce/xfdesktop/commit?id=00c5f70a943194c36f73cc15b93ded7d2ac7c71b
Comment 2 Theo Linkspfeifer editbugs 2020-02-12 16:07:25 CET
A moved file does not appear on the desktop, so there is something not working properly yet.
Comment 3 Andre Miranda editbugs 2020-02-16 16:54:59 CET
And if you revert that change will it appear on the desktop?
Comment 4 Theo Linkspfeifer editbugs 2020-02-16 17:10:07 CET
Yes.

Does that mean that you cannot reproduce the problem?
Comment 5 Andre Miranda editbugs 2020-02-16 17:31:24 CET
On a second try, I was able to reproduce.
Comment 6 Theo Linkspfeifer editbugs 2020-03-03 19:00:43 CET
Created attachment 9528 
diff

This works. Not sure though if EVENT_CREATED should be put in an else block.
Comment 7 Git Bot editbugs 2020-03-24 00:35:49 CET
Andre Miranda referenced this bugreport in commit 3f54fd52169c52e952461ae89c499a30b87f370c

Fix regression caused by Bug #16342

https://git.xfce.org/xfce/xfdesktop/commit?id=3f54fd52169c52e952461ae89c499a30b87f370c
Comment 8 Andre Miranda editbugs 2020-03-24 00:36:20 CET
(In reply to Theo Linkspfeifer from comment #6)
> This works. Not sure though if EVENT_CREATED should be put in an else block.
If it's moved to #else newly created files (e.g. touch ~/Desktop/foo) won't appear until refresh.

The patch looks good, although now I'm not sure if we have to update Thunar, from my quick test removing MOVED_IN made no difference.

Bug #16342

Reported by:
Theo Linkspfeifer
Reported on: 2020-01-07
Last modified on: 2020-03-24

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Version:
4.14.1

Attachments

diff (845 bytes, patch)
2020-03-03 19:00 CET , Theo Linkspfeifer
no flags

Additional information