! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Possibility to configure shortcuts in thunar preferences via GUI
Status:
RESOLVED: MOVED
Severity:
enhancement

Comments

Description alexxcons editbugs 2020-01-04 18:23:26 CET
Instead of modification of "~/.config/Thunar/accels.scm" by hand, it would be nice to have a GUI for shortcut management.

Either by using directly https://developer.gnome.org/gtk3/stable/GtkShortcutsWindow.html, or by providing a custom GUI.

A custom GUI should be located in libxfce4ui, so that all xfce application can make use of it. (First to be discussed if such a solution would be fine for all devs)
Comment 1 alexxcons editbugs 2020-01-04 18:59:48 CET
"Go --> Open location" menu item  could be removed if we would have a GUI to configure shortcuts
Comment 2 Andre Miranda editbugs 2020-01-05 20:59:44 CET
AFAICT GtkShortcutsWindow only shows the shortcuts, it doesn't allow rebinding them.

Just for the record, Thunar already features key bindings to custom actions and for this depends on libxfce4kbd, we just need to think how to extend this to make default actions editable.

Anyway, I would postpone this until we migrate away from GtkAction/GtkUIManager.
Comment 3 alexxcons editbugs 2020-01-05 23:16:10 CET
(In reply to Andre Miranda from comment #2)
> AFAICT GtkShortcutsWindow only shows the shortcuts, it doesn't allow
> rebinding them.
Hah, that third picture on the linked gtk doc page has a enum button "editor shortcuts" .. I only scimmed the page quickly and read "edit shortcuts" :P .... ok, so than GtkShortcutsWindow is not an option.

> Just for the record, Thunar already features key bindings to custom actions
> and for this depends on libxfce4kbd, we just need to think how to extend
> this to make default actions editable.
Agreed .. I missed that we already have a own lib for that.

> Anyway, I would postpone this until we migrate away from
> GtkAction/GtkUIManager.
Yes, definately.
Comment 4 alexxcons editbugs 2020-05-05 08:46:43 CEST
When going for such a GUI approch, we should make as many shortcuts as possible configurable to be able to check for collisions.

As well exo would need to be fixed in a way that the shortcuts to use are injected, not hard-coded.
Comment 5 Git Bot editbugs 2020-05-26 23:48:00 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/thunar/-/issues/279.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #16334

Reported by:
alexxcons
Reported on: 2020-01-04
Last modified on: 2020-05-26

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Attachments

Additional information