! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Broken Drag&Drop in deskbar mode
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Window Buttons

Comments

Description hededrk 2019-12-23 15:17:53 CET
Created attachment 9333 
Fix for the issue

Basically, when dragging&dropping, window buttons in deskbar mode work *as though they are horizontal*, even though they are laid-out *vertically*.
Comment 1 hededrk 2019-12-23 15:18:22 CET
Created attachment 9334 
Demonstration of undesired behaviour
Comment 2 hededrk 2019-12-23 15:19:43 CET
Comment on attachment 9334 
Demonstration of undesired behaviour


When Sorting order is set to “None, allow Drag&Drop”, drag&drop
behaviour is counter-intuitive: in deskbar mode window buttons are
arranged *vertically*, but the checks to determine whether to put
the button before or after the cursor are done *horizontal* coordinate.

In other words, when dragged button is dropped on top of another
button, it checks if it was dropped on left or right half, instead of
checking for top/bottom half.

This leads to a counter-intuitive behaviour: when I drop one button
"between" two other buttons, the position where the button is actually
dropped is seemingly random.
Comment 3 hededrk 2019-12-23 15:20:42 CET
Old bug report: https://bugzilla.xfce.org/show_bug.cgi?id=11781
Comment 4 Git Bot editbugs 2019-12-28 20:46:27 CET
Hudd referenced this bugreport in commit 07491d3372e464b50f28a42e0c79233d4d73b4fd

tasklist: Fix drag&drop in deskbar mode (Bug #16298)

https://git.xfce.org/xfce/xfce4-panel/commit?id=07491d3372e464b50f28a42e0c79233d4d73b4fd
Comment 5 Git Bot editbugs 2019-12-28 20:48:31 CET
Hudd referenced this bugreport in commit 9312580b92190fe6adcf197dab41cccce46eb972

tasklist: Fix drag&drop in deskbar mode (Bug #16298)

https://git.xfce.org/xfce/xfce4-panel/commit?id=9312580b92190fe6adcf197dab41cccce46eb972
Comment 6 Simon Steinbeiss editbugs 2019-12-28 20:49:40 CET
Thanks for the fix - makes sense! Pushed it to master and the 4.14 maintenance branch.

I adjusted the explanation in the commit to a developer's point of view (as users aren't likely to read commit notes).

Bug #16298

Reported by:
hededrk
Reported on: 2019-12-23
Last modified on: 2019-12-28

People

Assignee:
Simon Steinbeiss
CC List:
2 users

Version

Version:
4.14.1

Attachments

Fix for the issue (1.77 KB, patch)
2019-12-23 15:17 CET , hededrk
no flags
Demonstration of undesired behaviour (318.39 KB, video/mp4)
2019-12-23 15:18 CET , hededrk
no flags

Additional information