! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Context menu items are not fully translatable
Status:
RESOLVED: FIXED

Comments

Description Thomas Lange 2019-12-17 20:46:11 CET
The context menu items in the data- / audio composition window are not fully translatable.
Only if the label value is used somewhere else in the code by chance, it appears in the translation files.

The UI strings should be exported as separate XML files which can then be added to "POTFILES.in".
Another option would be to create the interfaces in code.

See also:
- https://git.xfce.org/apps/xfburn/tree/xfburn/xfburn-data-composition.c#n276
- https://git.xfce.org/apps/xfburn/tree/xfburn/xfburn-audio-composition.c#n295
Comment 1 Rene Kjellerup editbugs 2019-12-19 22:37:12 CET
Created attachment 9318 
patch implementing the context menu

the attached patch is the consolidation of the 3 stages

1. extracting the menus as a UI file and adding it to the build
  and translations
2. updating audio composition code to use the new context ui
3. the same update for data composition
Comment 2 Rene Kjellerup editbugs 2019-12-19 22:42:05 CET
the change as a merge request on my gitlab:
https://gitlab.com/Katana-Steel/xfburn/merge_requests/2/diffs
Comment 3 Thomas Lange 2019-12-19 22:57:13 CET
Thanks for the proposed fix, your patch works fine.
But I would still add the XML declaration (<?xml version="1.0" encoding="utf-8"?>), like in xfburn.ui.
Comment 4 Git Bot editbugs 2019-12-20 03:07:41 CET
Rene Kjellerup referenced this bugreport in commit 3ede662d30006530325a7e77d915e24e4e2df6b3

Adding a popup UI file for context menus (1/3)

https://git.xfce.org/apps/xfburn/commit?id=3ede662d30006530325a7e77d915e24e4e2df6b3
Comment 5 Git Bot editbugs 2019-12-20 03:07:44 CET
Rene Kjellerup referenced this bugreport in commit 1043053506babc42c6da2101b48df2fb1eda9d0f

Updated Audio Composition to define context menu from file (2/3)

https://git.xfce.org/apps/xfburn/commit?id=1043053506babc42c6da2101b48df2fb1eda9d0f
Comment 6 Git Bot editbugs 2019-12-20 03:07:46 CET
Rene Kjellerup referenced this bugreport in commit 8d4073704bae166e7598f05ab4333ed36c20324b

Updated Data Composition to define the context menu from file (3/3)

https://git.xfce.org/apps/xfburn/commit?id=8d4073704bae166e7598f05ab4333ed36c20324b
Comment 7 Rene Kjellerup editbugs 2019-12-20 03:13:23 CET
Added the XML header for good measure too :)

Thank you for checking/testing it.

Fix pushed to master

Bug #16282

Reported by:
Thomas Lange
Reported on: 2019-12-17
Last modified on: 2019-12-20

People

Assignee:
Rene Kjellerup
CC List:
1 user

Version

Attachments

patch implementing the context menu (7.97 KB, patch)
2019-12-19 22:37 CET , Rene Kjellerup
no flags

Additional information