! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Use the symbolic icon for eject in the sidebar
Status:
RESOLVED: FIXED

Comments

Description Simon Steinbeiss editbugs 2019-12-17 09:33:45 CET
I would suggest to use the symbolic variant of the media eject button, even when keeping the rest of the icons colored (see patch attached).
Comment 1 Simon Steinbeiss editbugs 2019-12-17 09:34:22 CET
Created attachment 9315 
Patch with symbolic icon name
Comment 2 Simon Steinbeiss editbugs 2019-12-17 09:34:37 CET
And just to be sure: I checked that the icon is part of the Adwaita icon theme
Comment 3 alexxcons editbugs 2019-12-19 10:26:29 CET
Fine for me ! Tested as well Tango, Breeze, Breeze-Dark, Oxygen and GNOME, works fine for all of them.

To my surprise "locate media-eject-symbolic" only showed an entry for Adwaita and breeze. So I assume if the symbolic one is not found, the standard "media-eject" will be used as default.
Comment 4 Git Bot editbugs 2019-12-19 10:27:04 CET
Simon Steinbeiss referenced this bugreport in commit b5daef31fb23f3e28a461afe69d0ca5f032c8212

Use symbolic icon for eject (Bug #16281)

https://git.xfce.org/xfce/thunar/commit?id=b5daef31fb23f3e28a461afe69d0ca5f032c8212

Bug #16281

Reported by:
Simon Steinbeiss
Reported on: 2019-12-17
Last modified on: 2019-12-19

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Version:
unspecified

Attachments

Patch with symbolic icon name (1.10 KB, patch)
2019-12-17 09:34 CET , Simon Steinbeiss
no flags

Additional information