! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
License text box is too small
Status:
RESOLVED: FIXED
Product:
Libxfce4ui
Component:
General

Comments

Description Hussam Al-Tayeb 2019-12-08 22:30:02 CET
Created attachment 9300 
Attached screenshot.

The License text box in xfce4-about -> "Copyright" -> "GPL", "LGPL", and "BSD" buttons is too small.
See attached screenshot.
Comment 1 Hussam Al-Tayeb 2019-12-09 18:51:07 CET
A simple glade modification to the glade ui file fixed this for me:

--- a/xfce4-about/xfce4-about-dialog.glade
+++ b/xfce4-about/xfce4-about-dialog.glade
@@ -307,7 +307,7 @@ NO WARRANTY
             </child>
           </object>
           <packing>
-            <property name="expand">False</property>
+            <property name="expand">True</property>
             <property name="fill">True</property>
             <property name="position">1</property>
           </packing>
Comment 2 Hussam Al-Tayeb 2019-12-09 18:53:03 CET
Ignore the first "glade" in that sentence. Sorry. I get confused when multitasking.
Comment 3 Andre Miranda editbugs 2019-12-29 13:33:36 CET
Can you please attach a patch generated with git format-patch?
Comment 4 Hussam Al-Tayeb 2019-12-29 14:05:24 CET
Created attachment 9336 
set expand property to true.

Sure.
Comment 5 Andre Miranda editbugs 2019-12-29 14:12:26 CET
That's not a patch, with git format-patch it contains commit (author/date) information. If you don't care about attributions, let me know so I can push the patch as if I authored it.

If you are still interested sending a proper patch, you first need to commit your changes and then run "git format-patch -1".
Comment 6 Hussam Al-Tayeb 2019-12-29 14:21:27 CET
You can push it as it is.
Comment 7 Git Bot editbugs 2019-12-29 14:27:41 CET
Andre Miranda referenced this bugreport in commit 74185009b1c002cab4e180011d77c64ba23e2c77

Fix license text box too small (Bug #16259)

https://git.xfce.org/xfce/libxfce4ui/commit?id=74185009b1c002cab4e180011d77c64ba23e2c77
Comment 8 Andre Miranda editbugs 2019-12-29 14:28:09 CET
Thanks for reporting and pointing the fix!

Bug #16259

Reported by:
Hussam Al-Tayeb
Reported on: 2019-12-08
Last modified on: 2020-01-14

People

Assignee:
Xfce Bug Triage
CC List:
2 users

Version

Version:
4.15.0

Attachments

Attached screenshot. (40.27 KB, image/png)
2019-12-08 22:30 CET , Hussam Al-Tayeb
no flags
set expand property to true. (533 bytes, patch)
2019-12-29 14:05 CET , Hussam Al-Tayeb
no flags

Additional information