! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
catfish v1.4.10 can't find files dated after Aug 1, 2019
Status:
RESOLVED: FIXED
Product:
Catfish
Component:
General

Comments

Description omui 2019-11-30 21:47:01 CET
Hi Team,

I may have noticed a potential bug.

Observations:

1. On 3 computers running Arch with catfish v1.4.10: catfish was NOT able to find files dated after Aug 1, 2019.

2. On the 4th computer running Arch with v1.4.9: catfish was able find files up to today (Nov 30, 2019).

3. After upgrading the 4th computer to v1.4.10, problem appeared: it could no longer find files dated after Aug 1, 2019.

4. Running catfish with -v or -vv did not show much.

5. Downgrading all 4 computers to v1.4.9 eliminated the problem. Upgrading back to v1.4.10 and the problem re-appeared.

5. catfish on Ubuntu 19.10 was v1.4.7, so even if it rans well, I couldn't rule out whether the problem was caused by packaging (ubuntu vs arch) or by v1.4.10.

6. So I tried Fedora 31 live iso with catfish v1.4.10, and it had exactly the same problem.

So it appearred that the problem was with catfish v1.4.10.

How to reproduce the problem:
1. Install catfish v1.4.9, search a file known to be dated before Aug 1, 2019, expected result: catfish can find it
2. Then upgrade to v1.4.10, search this file again, expected result: catfish cannot find it now.

Could someone please try to verify and fix the bug?

Thank you very much!
Comment 1 omui 2019-11-30 21:49:04 CET
Sorry here's how to reproduce the problem:

How to reproduce the problem:
1. Install catfish v1.4.9, search a file known to be dated AFTER Aug 1, 2019, expected result: catfish can find it
2. Then upgrade to v1.4.10, search this file again, expected result: catfish cannot find it now.
Comment 2 Filip Brygidyn 2019-12-02 20:18:56 CET
I tested your scenario and couldn't reproduce the issue, but I am fairly certain what is going on.

This is probably the same bug as this: https://bugzilla.xfce.org/show_bug.cgi?id=15985

You can test it by looking for files that are in a subdirectory - they should show up regardless of the date:
So instead of having:
'some_dir->ghost.file' structure and running 'catfish some_dir ghost'

try the following:
'some_dir->subdir->ghost.file' and run 'catfish some_dir ghost'
The file should be found regardless of the creation/modification date.

Or just apply the patch I attached in that bug report.

The behavior you are seeing about post Aug 1st files is most likely the result of 'locate' database being from that period.

From my limited knowledge about catfish internals I can say that it uses 3 methods:
- locate, which uses a preexisting file database - go to 'man locate' for details
- walk, which is supposed to simply traverse the file-system and find all matching files. 
- zeitgeist, which I do not use and as far as I understand will use event database that zeitgeist service gathers. Can't really speak much about it.

You also most likely do not use zeitgeist, and with outdated locate database 'walk' should find all the files but as I described in the bug linked above it appears to be broken in 1.4.10.
Comment 3 Sean Davis editbugs 2019-12-19 11:48:14 CET
This issue should be resolved with Filip's patches I applied here:

https://bugzilla.xfce.org/show_bug.cgi?id=15985#c8

Bug #16233

Reported by:
omui
Reported on: 2019-11-30
Last modified on: 2019-12-19

People

Assignee:
Sean Davis
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information