! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
autohide animation interacts poorly with fluxbox, please make optional
Status:
RESOLVED: FIXED
Product:
Xfce4-panel

Comments

Description Glen Whitney 2019-11-25 23:15:26 CET
Created attachment 9276 
patch to implement requested panel option

xfce4-panel recently added a slide animation to hiding the panel. However, this animation seems to interact poorly with the fluxbox window manager, which I use instead of xfwm4, leading to a cascade of X events which brings my X server to its knees. I kindly request that the animation be made optional.

I have created a pull request on github xfce4-mirror/xfce4-panel to implement this requested change; I have attached the contents of the pull request as a patch to this issue report. The patch adds a parameter to the panel preferences to select that the auto hide style be "Slide" (for the new animated version) or "collapse" (for an instant departure of the panel). With my panels set to collapse, I find the destructive interaction with fluxbox to be eliminated.

Please consider either adopting this patch or implementing some other means by which the animation would be optional, if there is some difficulty with the patch from your point of view. Thank you very much for your consideration.
Comment 1 Simon Steinbeiss editbugs 2019-12-02 22:35:44 CET
Hi, thanks for the report. I never expected this to have such side-effects. I'll take a look into a meaningful solution.

Meanwhile thanks for the patch!
Comment 2 Simon Steinbeiss editbugs 2020-01-05 19:10:39 CET
@Glen: Could you please post the output of "wmctrl -m" running Fluxbox?

Instead of making it optional I would prefer to simply disable the animation in Fluxbox instead.
Comment 3 Glen Whitney 2020-01-05 21:56:23 CET
> wmctrl -m

Name: Fluxbox
Class: N/A
PID: N/A
Window manager's "showing the desktop" mode: N/A

(Or should it be off unless the window manager is xfwm? Just thinking aloud. Maybe Fluxbox is the only old, crufty window manager... but there are a lot of window managers out there. Thanks for working on this!)
Comment 4 Simon Steinbeiss editbugs 2020-01-05 23:45:56 CET
Not sure how many people combine the Xfce Panel with other window managers.
I'd start with disabling the animation for Fluxbox and if more people report bugs I could still switch to only enabling it with Xfwm4 (or even making it optional, although I really don't like adding an option for every bit of code..)
Comment 5 Simon Steinbeiss editbugs 2020-01-29 21:31:04 CET
I tried to reproduce your problem with fluxbox now - I can't really reproduce the problem. It seems to slide out very smoothly.

Could you provide a few more details on what/how it interacts poorly or what I could do to reproduce your problem?
(Testing Fluxbox 1.3.5 on Xubuntu.)
Comment 6 Simon Steinbeiss editbugs 2020-02-03 13:12:40 CET
Alright, so instead of adding per-window-manager workarounds I decided to make the whole animation speed configurable after all.

So if you set "popdown-speed" to 0 in your panel the autohide animation will be disabled.
https://git.xfce.org/xfce/xfce4-panel/commit/?id=1a89fa8c591dde8afa7555a5d281e908aba08f26

Bug #16221

Reported by:
Glen Whitney
Reported on: 2019-11-25
Last modified on: 2020-02-03

People

Assignee:
Simon Steinbeiss
CC List:
1 user

Version

Version:
4.15.0

Attachments

patch to implement requested panel option (14.28 KB, text/plain)
2019-11-25 23:15 CET , Glen Whitney
no flags

Additional information