User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060314 Ubuntu/dapper Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060314 Ubuntu/dapper Firefox/1.5.0.1

When the icon is not found in the installed themes, the showdesktop plugin should not use and unref it. Spotted by seeing warnings from xfce4-panel on the console.

Index: plugins/showdesktop/showdesktop.c
===================================================================
--- plugins/showdesktop/showdesktop.c   (revision 20593)
+++ plugins/showdesktop/showdesktop.c   (working copy)
@@ -67,8 +67,10 @@
                                     sdd->button->style->ythickness);

     pb = xfce_themed_icon_load (SHOW_DESKTOP_ICON_NAME, width);
-    gtk_image_set_from_pixbuf (GTK_IMAGE (sdd->image), pb);
-    g_object_unref (pb);
+    if (pb) {
+        gtk_image_set_from_pixbuf (GTK_IMAGE (sdd->image), pb);
+        g_object_unref (pb);
+    }
     gtk_widget_set_size_request (GTK_WIDGET (plugin), size, size);

     return TRUE;


Reproducible: Always