! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Feature to support Excludes of thumbnail generation
Status:
RESOLVED: FIXED
Product:
Tumbler
Component:
General

Comments

Description Markus Kolb 2019-11-07 21:40:34 CET
Created attachment 9191 
tumbler-excludes.patch

Hi,

here is a patch to introduce a new config option Excludes.
It is quite limited to configure directories with only the Locations option.

My use case is a Download-directory which gets virus-scanned on opening files.
Well, tumbler also opens existing files to create thumbnails and so these files get also scanned by antivir-engine.
This is not the intention and an extreme CPU usage of antivir-engine when just visiting the directory.

With Locations option I would need to maintain a very long directory positive list where it is ok to create thumbnails for.
Just to exclude one directory.
That is not handy.

With Excludes I simply specify a single directory to exclude, and all other Locations are "thumbnailed".

The internal stuff works like for the Locations.

Any questions?

br
Markus
Comment 1 Ali Abdallah editbugs 2020-04-28 18:34:11 CEST
Hi Markus, sorry for the huge delay and thanks for your valuable contribution, I'll review it very soon and include it in the next release.
Comment 2 Git Bot editbugs 2020-05-01 14:14:27 CEST
Ali Abdallah referenced this bugreport in commit 3520322eb453ee1349b14b080a0f7d23e4040b16

This commit implements Excludes paths

https://gitlab.xfce.org/xfce/tumbler/commit/3520322eb453ee1349b14b080a0f7d23e4040b16

Bug #16130

Reported by:
Markus Kolb
Reported on: 2019-11-07
Last modified on: 2020-05-17

People

Assignee:
Ali Abdallah
CC List:
0 users

Version

Version:
unspecified

Attachments

tumbler-excludes.patch (6.97 KB, patch)
2019-11-07 21:40 CET , Markus Kolb
no flags

Additional information