User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060314 Ubuntu/dapper Firefox/1.5.0.1 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060314 Ubuntu/dapper Firefox/1.5.0.1 Use the same icon in the desktopfile as in the code Index: plugins/showdesktop/showdesktop.desktop.in.in =================================================================== --- plugins/showdesktop/showdesktop.desktop.in.in (revision 20593) +++ plugins/showdesktop/showdesktop.desktop.in.in (working copy) @@ -3,6 +3,6 @@ Encoding=UTF-8 _Name=Show Desktop _Comment=Toggle desktop show/hide -Icon=xfce-desktop +Icon=gnome-fs-desktop X-XFCE-Module=@INTERNAL_PLUGIN_PATH@/libshowdesktop.so Reproducible: Always
I don't really want to depend on gnome icons, so we should either copy the gnome one, or create a new xfce-desktop icon. The same holds for other plugin icons or the ones using the mouse icon.
this icon is not just a gnome icon. It is in the rodent theme too. The code uses this icon already. It does not seem to be falling back to others or be more error-proof than putting it in the desktop file. What am I missing?
(In reply to comment #2) > this icon is not just a gnome icon. It is in the rodent theme too. The code > uses this icon already. It does not seem to be falling back to others or be > more error-proof than putting it in the desktop file. What am I missing? > oh, right, I didn't know it was in rodent... Hmm, that really should be sufficient, but I have always put fallback icons in the panel, so we didn't need to depend on any icon theme (including rodent). I'll think about it some more. And then I will probably add your patch ;-)
Fixed in rev. 20987. Thanks.