! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Add a --disable-wm-check flag like that of xfdesktop and xfce4-panel
Status:
RESOLVED: FIXED
Product:
Xfce4-settings
Component:
Xfsettingsd

Comments

Description Glen Whitney 2019-11-06 21:58:13 CET
Created attachment 9190 
patch to implement requested flag

Both xfdesktop and xfce4-panel have a --disable-wm-check command line option, presumably to allow xfce4 to be used with an alternate window manager (e.g. fluxbox) that does not use the same hints that xfwm4 uses (ownership of the WM_S0, WM_S1, etc. selections) to register its operation. However, xfsettingsd still waits for these hints during session startup. Please add a --disable-wm-check option to not wait for these window manager hints, to make it consistent with the other xfce4 components and to allow a full session startup with an alternate window manager but without waiting for the check to time out. I have provided a patch which does so, cf. https://github.com/xfce-mirror/xfce4-settings/pull/5
Comment 1 Simon Steinbeiss editbugs 2020-02-03 16:09:36 CET
Created attachment 9423 
Disable wm check flag

Thanks for your patch. I have reviewed and amended it a bit, please take a look before I merge it.

Also, I'm not sure we'll be able to merge it in 4.14 as this changes strings and isn't strictly speaking bugfix-only. Will probably have to chat with some of the other devs about this.
Comment 2 Git Bot editbugs 2020-02-28 22:06:48 CET
Glen Whitney referenced this bugreport in commit a244e5a6069acf200b6a25b25d19506d2b96bfcc

xfsettingsd: Add --disable-wm-check flag (Bug #16128)

https://git.xfce.org/xfce/xfce4-settings/commit?id=a244e5a6069acf200b6a25b25d19506d2b96bfcc
Comment 3 Simon Steinbeiss editbugs 2020-02-28 22:07:38 CET
Merged into master targeting Xfce 4.16

Bug #16128

Reported by:
Glen Whitney
Reported on: 2019-11-06
Last modified on: 2020-02-28

People

Assignee:
Simon Steinbeiss
CC List:
1 user

Version

Version:
4.14.1

Attachments

patch to implement requested flag (3.32 KB, text/plain)
2019-11-06 21:58 CET , Glen Whitney
no flags
Disable wm check flag (3.40 KB, patch)
2020-02-03 16:09 CET , Simon Steinbeiss
no flags

Additional information