Created attachment 9185
Patch that adds the xfce_sm_client_set_desktop_file call
Currently the session manager doesn't know about xfce4-terminal's application name and icon. It's a single call that passes the .desktop file to xfsm so it can show this information correctly in the "Current Session" tab of xfce4-session-settings.
The patch attached fixes the issue.
Simon Steinbeiss referenced this bugreport in commit 492d7b5db387db15fdca849d229db67fc1a9d4f7
Point session manager to desktop file