! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Countdown shouldn't happen when configuration was changed but countdown itsel...
Status:
RESOLVED: FIXED
Product:
Xfce4-time-out-plugin
Component:
General

Comments

Description Alexey Ugnichev 2019-11-03 19:49:04 CET
There is now a problem with a logic behind the check for a restart event, leading to some erroneous behavior (i.e. it's currently resuming a countdown if the "time between breaks" value has changed during a setup dialog, regardless of the fact if the countdown itself is enabled or not).

Pull request with a possible fix: https://github.com/xfce-mirror/xfce4-time-out-plugin/pull/3
Comment 1 Git Bot editbugs 2020-02-11 04:53:47 CET
Alexey Ugnichev referenced this bugreport in commit a6b8e157be2c88e9d5576d31c4e5e00eb4d6d7c4

Do not enable countdown when configuration changes (Bug #16118)

https://git.xfce.org/panel-plugins/xfce4-time-out-plugin/commit?id=a6b8e157be2c88e9d5576d31c4e5e00eb4d6d7c4
Comment 2 Andre Miranda editbugs 2020-02-11 04:55:28 CET
Hi Alexey, thanks for the report and the fix, I just added a couple of braces to make that if more clear and simplified the commit message.
Comment 3 Alexey Ugnichev 2020-02-11 05:08:11 CET
Well done, thanks!

Bug #16118

Reported by:
Alexey Ugnichev
Reported on: 2019-11-03
Last modified on: 2020-02-11

People

Assignee:
Xfce-Goodies Maintainers
CC List:
1 user

Version

Attachments

Additional information