! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
"Current Configuration" is not really current configuration
Status:
RESOLVED: FIXED
Product:
Xfce4-panel-profiles
Component:
General

Comments

Description ema-pe 2019-11-02 12:38:00 CET
Hi, I noticed that "Current Configuration" is not the real current configuration, because it is a generated configuration file at application startup[0]. If you modify the panel after you opened xfce4-panel-profiles and then apply "Current Configuration", the old panel is restored. I think this is a bug.

My solution: get rid of caching the current panel configuration, it is better to generate it only if the user want to export or copy it.

[0]: https://git.xfce.org/apps/xfce4-panel-profiles/tree/xfce4-panel-profiles/xfce4-panel-profiles.py#n382
Comment 1 ema-pe 2019-11-02 14:10:56 CET
Created attachment 9176 
Patch that solves the bug.

This is my proposed patch. I removed all code related to caching current configuration, I also fixed 'apply' button when current configuration is selected.
Comment 2 Simon Steinbeiss editbugs 2019-11-04 09:52:19 CET
I'm a fan of this approach - makes sense to me!
Comment 3 Git Bot editbugs 2019-11-26 11:58:44 CET
Emanuele Petriglia referenced this bugreport in commit 2bd963527c84595292df038465220631cff81bc7

Do not cache current configuration (Bug #16114)

https://git.xfce.org/apps/xfce4-panel-profiles/commit?id=2bd963527c84595292df038465220631cff81bc7
Comment 4 Sean Davis editbugs 2019-11-26 11:59:07 CET
Thanks for the patch! Applied above.

Bug #16114

Reported by:
ema-pe
Reported on: 2019-11-02
Last modified on: 2019-11-26

People

Assignee:
Sean Davis
CC List:
2 users

Version

Version:
unspecified

Attachments

Patch that solves the bug. (3.81 KB, patch)
2019-11-02 14:10 CET , ema-pe
no flags

Additional information