! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Unconditionally enable compositing for CSD windows.
Status:
RESOLVED: WONTFIX

Comments

Description Hussam Al-Tayeb 2019-10-24 19:55:46 CEST
If ran without compositing on, CSD windows show a large black border around the entire window.
Even ones without a header back will do that. For example, run "GTK_CSD=1 xfce4-settings-manager".
If "Enable display compositing" is disabled, those windows show an ugly black border all around the window.
So please explicitly enable compositing for such windows and only disable it for non CSD windows.

Thank you.
Comment 1 Hussam Al-Tayeb 2019-10-24 19:56:27 CEST
I mean to type "Even ones without a header bar will do that".
Comment 2 Olivier Fourdan editbugs 2019-10-24 20:09:29 CEST
Compositing is a global thing, it's not per window.
Comment 3 Hussam Al-Tayeb 2019-10-24 20:21:14 CEST
Ok, thank you for the reply.
At some point though, it will need to be permanently enabled as 4.16 will start experimenting with client side decorations according to https://simon.shimmerproject.org/2019/10/19/xfce-4-15-development-phase-starting/
Comment 4 Olivier Fourdan editbugs 2019-10-25 08:27:58 CEST
GTK supports CSD without compositing, so not required.
Comment 5 Hussam Al-Tayeb 2019-10-25 08:43:16 CEST
In this screenshot https://i.imgur.com/t0lD6AW.png:
1) the ssd windows look ok without compositing.
2) The windows with headerbars look bad without compositing (GTK_CSD is not set).
3) Non header bar windows look bad with GTK_CSD=1.

Basically, the issue is happening for windows in point 2.
Comment 6 Olivier Fourdan editbugs 2019-10-25 09:06:01 CEST
(In reply to Hussam Al-Tayeb from comment #0)
> If ran without compositing on, CSD windows show a large black border around
> the entire window.
> If "Enable display compositing" is disabled, those windows show an ugly
> black border all around the window.

I see where the confusion comes from here...

As I said in comment 4, GTK supports CSD without a compositor [1] but it does not monitor the property continuously (as very window managers/compostior are able to enable/disable compositing on the fly), so you need to restart the GTK applications if you enable/disable compositing.

Thy this instead:

1. Disable compositing
2. Start gtk3-demo after
3. Check CSD windows

[1] https://gitlab.gnome.org/GNOME/gtk/commit/03213b950
Comment 7 Hussam Al-Tayeb 2019-10-25 09:21:39 CEST
Ok, got it. Thank you. I wasn't restarting GTK applications after toggling the composting option.
Thanks again.

Bug #16089

Reported by:
Hussam Al-Tayeb
Reported on: 2019-10-24
Last modified on: 2019-10-25

People

Assignee:
Olivier Fourdan
CC List:
0 users

Version

Version:
4.14.0

Attachments

Additional information