! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Build failure against xfce4-panel 4.15.0
Status:
RESOLVED: FIXED
Product:
Xfce4-whiskermenu-plugin
Component:
General

Comments

Description Michał Górny 2019-10-20 18:28:40 CEST
Created attachment 9134 
/var/log/portage/xfce-extra:xfce4-whiskermenu-plugin-2.3.3:20191020-162159.log

The plugin fails to compile w/ xfce4-panel 4.15.0. The exact error below.

Changing the include to <libxfce4panel/libxfce4panel.h> (like in [1]) helps.

[1] https://git.xfce.org/panel-plugins/xfce4-smartbookmark-plugin/commit/?id=856d73b51f5d237d3cf6792f5e9f55220e5facf1

---

FAILED: panel-plugin/CMakeFiles/whiskermenu.dir/register-plugin.c.o 
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-gcc-9.2.0 -DBINDIR=\"/usr/bin\" -DDATADIR=\"/usr/share\" -DGETTEXT_PACKAGE=\"xfce4-whiskermenu-plugin\" -DGSEAL_ENABLE -DGTK_MULTIHEAD_SAFE -DG_LOG_DOMAIN=\"whiskermenu\" -DPACKAGE_LOCALE_DIR=\"/usr/share/locale\" -DPACKAGE_NAME=\"xfce4-whiskermenu-plugin\" -DPACKAGE_VERSION=\"2.3.3\" -DSETTINGS_MENUFILE=\"/etc/xdg/menus/xfce-settings-manager.menu\" -Dwhiskermenu_EXPORTS -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/gio-unix-2.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/fribidi -I/usr/include/atk-1.0 -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -I/usr/lib64/libffi-3.3_rc0/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/exo-2 -I/usr/include/xfce4 -I/usr/include/garcon-1 -I/usr/include/xfce4/libxfce4panel-2.0 -I/usr/include/xfce4/libxfce4ui-2  -DNDEBUG -march=x86-64 -mtune=k8 -mcx16 -msahf -msse3 --param l1-cache-size=64 --param l1-cache-line-size=64 --param l2-cache-size=512 -O2 -pipe -frecord-gcc-switches -Wall -Wextra -fPIC   -pthread -pthread -pthread -pthread -pthread -MD -MT panel-plugin/CMakeFiles/whiskermenu.dir/register-plugin.c.o -MF panel-plugin/CMakeFiles/whiskermenu.dir/register-plugin.c.o.d -o panel-plugin/CMakeFiles/whiskermenu.dir/register-plugin.c.o -c /tmp/portage/xfce-extra/xfce4-whiskermenu-plugin-2.3.3/work/xfce4-whiskermenu-plugin-2.3.3/panel-plugin/register-plugin.c
/tmp/portage/xfce-extra/xfce4-whiskermenu-plugin-2.3.3/work/xfce4-whiskermenu-plugin-2.3.3/panel-plugin/register-plugin.c:22:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
   22 | XFCE_PANEL_PLUGIN_REGISTER(whiskermenu_construct)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/portage/xfce-extra/xfce4-whiskermenu-plugin-2.3.3/work/xfce4-whiskermenu-plugin-2.3.3/panel-plugin/register-plugin.c: In function ‘XFCE_PANEL_PLUGIN_REGISTER’:
/tmp/portage/xfce-extra/xfce4-whiskermenu-plugin-2.3.3/work/xfce4-whiskermenu-plugin-2.3.3/panel-plugin/register-plugin.c:22:1: warning: type of ‘whiskermenu_construct’ defaults to ‘int’ [-Wimplicit-int]
/tmp/portage/xfce-extra/xfce4-whiskermenu-plugin-2.3.3/work/xfce4-whiskermenu-plugin-2.3.3/panel-plugin/register-plugin.c:22: error: expected ‘{’ at end of input
   22 | XFCE_PANEL_PLUGIN_REGISTER(whiskermenu_construct)
      | 
/tmp/portage/xfce-extra/xfce4-whiskermenu-plugin-2.3.3/work/xfce4-whiskermenu-plugin-2.3.3/panel-plugin/register-plugin.c:22:1: warning: unused parameter ‘whiskermenu_construct’ [-Wunused-parameter]
   22 | XFCE_PANEL_PLUGIN_REGISTER(whiskermenu_construct)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/portage/xfce-extra/xfce4-whiskermenu-plugin-2.3.3/work/xfce4-whiskermenu-plugin-2.3.3/panel-plugin/register-plugin.c:22:1: warning: control reaches end of non-void function [-Wreturn-type]
   22 | XFCE_PANEL_PLUGIN_REGISTER(whiskermenu_construct)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
Comment 1 Michał Górny 2019-10-20 18:32:50 CEST
Created attachment 9135 
Patch fixing the issue

And here's a trivial patch ;-).
Comment 2 Graeme Gott editbugs 2019-10-21 17:34:42 CEST
Thanks for the patch! Applied in commit 4c284a.

Bug #16066

Reported by:
Michał Górny
Reported on: 2019-10-20
Last modified on: 2019-10-21

People

Assignee:
Graeme Gott
CC List:
0 users

Version

Attachments

Additional information