! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Autohide animation breaks solid color panels
Status:
RESOLVED: FIXED
Product:
Xfce4-panel

Comments

Description ToZ editbugs 2019-10-20 04:32:18 CEST
With the new autohide animation code, panels with the background style set to solid color do not intelligently or always autohide. It works ok with the background style set to None. Maximized windows also display over the panel in this scenario.
Comment 1 Simon Steinbeiss editbugs 2019-10-20 11:41:32 CEST
Thanks for noticing - I would have never guessed that there is a side-effect coming from the background drawing...
Comment 2 Simon Steinbeiss editbugs 2019-10-20 12:03:48 CEST
Ok, so the root cause is we're not setting any borders when using custom backgrounds (color or image) so the autohide animation code is unsure about the panel's location.

I'll try to fix that after next week...
Comment 3 Git Bot editbugs 2019-10-20 12:11:33 CEST
Simon Steinbeiss referenced this bugreport in commit b39978985b90c5c3478aea8fab484d2f2707c4ac

Fix autohide with bg color or image (Bug #16064)

https://git.xfce.org/xfce/xfce4-panel/commit?id=b39978985b90c5c3478aea8fab484d2f2707c4ac
Comment 4 Simon Steinbeiss editbugs 2019-10-20 12:12:04 CEST
It turned out to be easier than expected, so it's fixed now.
Comment 5 ToZ editbugs 2019-10-20 13:59:06 CEST
Thanks Simon. Patch fixes the issue.

Bug #16064

Reported by:
ToZ
Reported on: 2019-10-20
Last modified on: 2019-10-20

People

Assignee:
Simon Steinbeiss
CC List:
1 user

Version

Version:
4.15.0

Attachments

Additional information