! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
invalid icons in weather properties dialog
Status:
RESOLVED: FIXED
Product:
Xfce4-weather-plugin
Component:
General

Comments

Description Hussam Al-Tayeb 2019-10-17 22:41:46 CEST
There are two invalid icons in weather properties dialog in the "Move up" and "Move down" buttons.

I took a screenshot. https://i.imgur.com/7WyxcnF.png
Comment 1 Harald Judt editbugs 2019-10-18 09:58:50 CEST
Maybe the theme you use doesn't provide them or your setup is faulty. With the (standard) awaita theme it shows two arrows here.
Comment 2 Hussam Al-Tayeb 2019-10-18 10:01:20 CEST
I have Adwaita as well version 3.34.0
Comment 3 Hussam Al-Tayeb 2019-10-18 10:02:16 CEST
What is the name of the icon files please so I can check if they are in the adwaita-icon-theme package?
Comment 4 Hussam Al-Tayeb 2019-10-18 14:47:54 CEST
Harald, is it possible you have gnome-icon-theme installed as well and Adwaita is set to inherit from it?
Comment 5 Harald Judt editbugs 2019-10-18 15:41:08 CEST
Hm. I have gnome-icon-theme-extras and -symbolic installed, both v3.12. I cannot answer the second question, I have not modified Adwaita but maybe my distribution does this. There is no gnome-icon-theme package in gentoo, it has been removed some time ago IIRC.
Comment 6 Theo Linkspfeifer editbugs 2019-10-18 23:25:57 CEST
https://git.xfce.org/panel-plugins/xfce4-weather-plugin/tree/panel-plugin/weather-config.ui#n56

Icon names are 'up' and 'down'. The xfce4-panel preferences dialog uses 'go-up' and 'go-down' instead.
Comment 7 Git Bot editbugs 2019-10-19 23:23:44 CEST
Andre Miranda referenced this bugreport in commit 9b10075594be707ff21ee09e4cdf8fc8aa8111d2

Use standard icon names (Bug #16059)

https://git.xfce.org/panel-plugins/xfce4-weather-plugin/commit?id=9b10075594be707ff21ee09e4cdf8fc8aa8111d2
Comment 8 Andre Miranda editbugs 2019-10-19 23:24:51 CEST
Hussam, can you please check if that commit fixes the problem for you?
Thanks Theo for spotting this.
Comment 9 Hussam Al-Tayeb 2019-10-20 12:39:16 CEST
This is indeed fixed now. Thank you looking into this.

Bug #16059

Reported by:
Hussam Al-Tayeb
Reported on: 2019-10-17
Last modified on: 2019-10-20

People

Assignee:
Harald Judt
CC List:
2 users

Version

Version:
0.8.10

Attachments

Additional information