! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
The keyboard settings dialog won't let me add key shortcuts.
Status:
RESOLVED: FIXED
Product:
Xfce4-settings
Component:
Keyboard Settings

Comments

Description Hussam Al-Tayeb 2019-10-16 16:42:49 CEST
The keyboard settings dialog won't let me add key shortcuts.
 I added a new app entry but it did not show up.
I see this warning in the console window.

I get the window to add a command but I am presented with the keybinding window.

(xfce4-keyboard-settings:354239): Gdk-CRITICAL **: 16:42:00.920: Window 0x5645c181d280 has not been made visible in GdkSeatGrabPrepareFunc
4:42 PM 
4:42 PM (xfce4-keyboard-settings:354239): libxfce4kbd-private-WARNING **: 16:42:00.920: Could not grab the keyboard.

I am running gtk 3.24.12 and apparently this is related to https://gitlab.gnome.org/GNOME/gtk/issues/1073 according to irc channel.
Comment 1 Hussam Al-Tayeb 2019-10-16 17:10:58 CEST
This is due to one of the depreciation fixes in the 4.14 branch https://git.xfce.org/xfce/libxfce4ui/log/?h=xfce-4.14 since 4.14.1 does not show this bug.
Comment 2 Andre Miranda editbugs 2019-10-17 04:49:53 CEST
Created attachment 9128 
quick fix

Either we go with this patch or keep the deprecated function.
Comment 3 Hussam Al-Tayeb 2019-10-17 16:23:15 CEST
I applied the patch locally and I just successfully binded the calculator key on my Microsoft Keyboard to launch a calculator program.

Are there any other areas that I should test for the original change?
Comment 4 Git Bot editbugs 2019-11-03 18:51:33 CET
Andre Miranda referenced this bugreport in commit c4023afce25b626f5e5af7df306ac7ac421f8b19

Fix Window has not been made visible when grabbing keyboard (Bug #16054)

https://git.xfce.org/xfce/libxfce4ui/commit?id=c4023afce25b626f5e5af7df306ac7ac421f8b19
Comment 5 Git Bot editbugs 2019-11-03 18:52:07 CET
Andre Miranda referenced this bugreport in commit 2e7193a93af190a7507cf28fd78314d00928cb3b

Fix Window has not been made visible when grabbing keyboard (Bug #16054)

https://git.xfce.org/xfce/libxfce4ui/commit?id=2e7193a93af190a7507cf28fd78314d00928cb3b
Comment 6 Andre Miranda editbugs 2019-11-03 18:52:58 CET
(In reply to Hussam Al-Tayeb from comment #3)
> I applied the patch locally and I just successfully binded the calculator
> key on my Microsoft Keyboard to launch a calculator program.
Thanks for reporting and testing.

Bug #16054

Reported by:
Hussam Al-Tayeb
Reported on: 2019-10-16
Last modified on: 2019-11-03

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Version:
4.14.1

Attachments

quick fix (2.58 KB, patch)
2019-10-17 04:49 CEST , Andre Miranda
no flags

Additional information