! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar doesn't update file icons on renaming when using remote locations
Status:
RESOLVED: MOVED

Comments

Description Alexander Kurakin 2019-10-11 16:14:09 CEST
1. Openn 'sftp://host'.
2. Create 'file.html' file.
3. You see HTML icon.
4. Rename: 'file.html' -> 'file.pdf'.
5. You see HTML icon instead of PDF icon (although filename is new).

Thunar 1.6 git branch.
Comment 1 alexxcons editbugs 2019-10-12 15:37:06 CEST
Thanks for reporting !
Bug as well exists on current master.
Only an issue for remote locations, because no folder/file monitors are available there. Pressing F5 will update the view manually and show the correct icon.

Note that the bug can as well be reproduced when entering "localhost" remotly. E.g: sftp://user@localhost/home/user/

Patches are welcome !
Comment 2 Alexander Kurakin 2019-10-12 23:41:02 CEST
> Patches are welcome 
Ok, but what does this:

> because no folder/file monitors are available there
could impact to, else?
Comment 3 alexxcons editbugs 2019-10-13 00:11:32 CEST
> Ok, but what does this

The rename is e.g. triggered in "thunar_standard_view_action_rename" inside thunar-standard-view.h
It would be good to call "thunar_file_reload" if the GFileMonitor of this file is NULL ( probably we need a method on ThunarFile to check that .. similar to thunar_folder_has_folder_monitor on ThunarFolder ).
Comment 4 Alexander Kurakin 2019-10-13 00:14:26 CEST
Thanks!

I meant, shouldn't we do it not at rename, only?
Comment 5 alexxcons editbugs 2019-10-13 00:22:44 CEST
yes, probably as well required on other operations .. (e.g. update folder on paste and cut .. probably whenever a custom action was triggered ) to be checked in detail
Comment 6 alexxcons editbugs 2020-05-04 09:05:08 CEST
*** Bug 12569 has been marked as a duplicate of this bug. ***
Comment 7 Git Bot editbugs 2020-05-26 23:45:55 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/thunar/-/issues/264.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #16030

Reported by:
Alexander Kurakin
Reported on: 2019-10-11
Last modified on: 2020-05-26
Duplicates (1):
  • 12569 Thunar doesn't properly reload; uses old cached bytes when copying causing corruption

People

Assignee:
Xfce Bug Triage
CC List:
3 users

Version

Version:
1.6.17

Attachments

Additional information