! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fix preventing an invalid option to be added in 'Labels to display' list
Status:
RESOLVED: FIXED
Product:
Xfce4-weather-plugin
Component:
General

Comments

Description Otávio Napoli 2019-10-08 23:53:51 CEST
Created attachment 9099 
Patch preventing an invalid option to be added in 'labels to display' list

Steps to Reproduce:
 1) Open the Weather Update properties
 2) Go to the 'Scrollbox' page
 3) With no label selected in the drop-down list, click in the add button
 4) As no label was selected from the drop-down list, an invalid label is added in the 'Labels to Display' list

The present patch prevents adding a new label to the 'Labels to display' list if nothing was selected from the drop-down list.
Comment 1 Otávio Napoli 2019-10-08 23:58:19 CEST
Created attachment 9100 
Screenshot of the bug
Comment 2 Git Bot editbugs 2020-01-07 03:24:33 CET
Otavio Napoli referenced this bugreport in commit 7336cb77b1587ce433c617f15063fae3188d2a72

Fix invalid scrollbar index to add a label (Bug #16023)

https://git.xfce.org/panel-plugins/xfce4-weather-plugin/commit?id=7336cb77b1587ce433c617f15063fae3188d2a72
Comment 3 Andre Miranda editbugs 2020-01-07 03:27:07 CET
Thanks for the patch, I just made a small modification to it.

Bug #16023

Reported by:
Otávio Napoli
Reported on: 2019-10-08
Last modified on: 2020-01-07

People

Assignee:
Harald Judt
CC List:
2 users

Version

Version:
0.10.0

Attachments

Additional information