! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xscreensaver desktop file has same name as xfce4-screensaver
Status:
RESOLVED: MOVED
Product:
Xfce4-session
Component:
General

Comments

Description Guido Falsi 2019-09-30 15:28:10 CEST
Hi,

In FreeBSD after updating xfce to 4.14 It has been noticed that xfce4-session installs a .desktop startup file for xscreensaver, enabled by default.

At the same time xfce4-screensaver installs it's own .desktop file, also enabled by default.

The two .desktop files happen to have the same exact content in the Name and comment fields. This is problematic because in the Application Autostart interface of the Session and Startup configuration tool the two entries appear identical and cannot be distinguished.

Another issue is that if both are installed, being both enabled by default, they end up conflicting. This can manifest it when the screen is locked as one of the two screensavers showing it's unlock UI while the other grabs the keyboard, preventing the user from properly unlocking the screen.

This has been reported in FreeBSD in these bug reports:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240804
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240810
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240811

In the FreeBSD ports we have a metaport (that is a port which installs nothing, but depends on other ports to force their installation) for xfce which by default also installs xfce4-screensaver. Due to this I have implemented two workarounds:

- Install the xscreensaver.desktop file with the line Hidden=true which disables it
- Change the Name field of xfce4-screensaver, so the lines can be distinguished in the Application Autostart UI

I'm attaching a patch including the first change and also changes the .desktop file name field. I have already filed a bug report for xfce4-screensaver with a similar change.

I understand that switching to disabled by default could not be the best choice for you. I also think a better name and description can be chosen.

I'm attaching the patch as an example of what can be done, and to start discussion.
Comment 1 Guido Falsi 2019-09-30 15:29:07 CEST
Created attachment 9061 
.desktop file patch
Comment 2 Git Bot editbugs 2020-05-26 00:51:15 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-session/-/issues/60.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #15999

Reported by:
Guido Falsi
Reported on: 2019-09-30
Last modified on: 2020-05-26

People

Assignee:
Xfce Bug Triage
CC List:
0 users

Version

Version:
4.14.0

Attachments

.desktop file patch (447 bytes, patch)
2019-09-30 15:29 CEST , Guido Falsi
no flags

Additional information