! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar custom actions + Catfish = No files found.


Description Anton 2019-09-23 00:13:36 CEST
catfish --path=%f doesn't work.

Catfish 1.4.10
Thunar 1.8.9
Arch Linux.
Comment 1 Anton 2019-09-23 00:20:13 CEST
catfish %f the same.
Comment 2 Filip Brygidyn 2019-11-09 19:38:24 CET
I think this is not a passed option fault.
The search is pretty broken since the commit 5cd2f114.
It appears that 'walk' method cannot find directories or anything that is directly in the selected directory.

If you experienced a situation that files start being found seemingly randomly then they are most likely found by 'locate' method.

You may have found another bug but please try the attached patch.
Comment 3 Filip Brygidyn 2019-11-09 19:39:48 CET
Created attachment 9199 
Comment 4 Filip Brygidyn 2019-12-03 22:54:07 CET
Ok, I would like to retract the patch I posted, I did not test it well enough.
Somewhere in between testing the locate database was updated and it appeared to me that the files started being found.
I had to force disable locate to notice the error.

The patch only makes regular directories to appear consistently. Files located directly in the selected search dir will still be missing.

I will try to take a second look when I have time this week.

2 side-notes:
- bug #16233 is probably a duplicate
- someone on reddit seems to have noticed the same behavior: https://old.reddit.com/r/xfce/comments/dxkj1i/catfish_cant_find_files_within_subfolders/
Comment 5 Filip Brygidyn 2019-12-07 18:30:24 CET
Created attachment 9294 

I am attaching a fixed patch - this time files in the root dir should not be ommited
Comment 6 Filip Brygidyn 2019-12-07 18:59:12 CET
Created attachment 9295 

I selected wrong patch in the previous post, this time it should be good -.-
Comment 7 Filip Brygidyn 2019-12-07 19:05:30 CET
Created attachment 9296 

I was also wondering about the possibility to simplify the traversal and as a result I prepared a patch that removes the get_root_list() method in favor of including it in the os.walk() call.
The prioritization an excludes still work.

Bug #15985

Reported by:
Reported on: 2019-09-23
Last modified on: 2019-12-19


Sean Davis
CC List:
1 user




proposed_patch (2.22 KB, patch)
2019-11-09 19:39 CET , Filip Brygidyn
no flags
proposed_patch_v2 (944 bytes, patch)
2019-12-07 18:30 CET , Filip Brygidyn
no flags
proposed_patch_v3 (3.70 KB, patch)
2019-12-07 18:59 CET , Filip Brygidyn
no flags
simplify_patch (4.30 KB, patch)
2019-12-07 19:05 CET , Filip Brygidyn
no flags

Additional information