! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Shortcut cannot be deleted
Status:
RESOLVED: FIXED

Comments

Description Manuel Grießmayr 2019-09-20 09:57:08 CEST
Click this URL:
https://www.amazon.de/Immer-%C3%84rger-Bernie-Andrew-McCarthy/dp/B000050HN1/ref=sr_1_1?s=dvd&ie=UTF8&qid=1526856948&sr=1-1&keywords=immer+%C3%A4rger+mit+bernie

Then drag 'n drop the Url from Firefox to the desktop or Thunar and try to delete the newly created shortcut. I get the error message: "Deletion protocol could not be created. File name is too long".

I am using Xubuntu 19.04 64 Bit.

The bug can be triggered with Thunar and Xfdesktop.
Comment 1 alexxcons editbugs 2019-09-20 23:11:54 CEST
Thanks for reporting, I can reproduce the bug on thunar master and xfdesktop 4.13.5
Comment 2 Andre Miranda editbugs 2019-10-04 04:34:41 CEST
Same issue with Nemo and Nautilus, the difference is that they offer to delete the file.
Comment 3 Theo Linkspfeifer editbugs 2019-10-05 13:53:43 CEST
I think the problem is that GVfs tries to create a file with the same name + ".trashinfo". This may exceed the file name length limit (usually 255 Bytes).

So, either adapt the behavior of Nautilus, or trim the file name before moving the file to the Trash.
Comment 4 Andre Miranda editbugs 2019-10-06 21:53:24 CEST
(In reply to Theo Linkspfeifer from comment #3)
> So, either adapt the behavior of Nautilus, or trim the file name before
> moving the file to the Trash.

The former is feature request, the latter is a hack that I'm not willing to push.
Comment 5 Theo Linkspfeifer editbugs 2019-10-30 16:09:59 CET
Is it a feature request though? The user should be able to delete the file without the need to use the command-line or turn on the hidden "Delete" menu entry.
Comment 6 Andre Miranda editbugs 2019-12-21 19:27:06 CET
Created attachment 9324 
quick fix
Comment 7 alexxcons editbugs 2019-12-21 22:15:38 CET
(In reply to Andre Miranda from comment #6)
> Created attachment 9324 
> quick fix

Works fine for me, nice !
The message of the window is a bit confusing .. would be nice to have something like "trashing failed" as heading .. how about that:
> response = thunar_job_ask_delete (job, "%s\n\n%s" ,_("Failed to Trash file"), err->message);

For the question at the end of the dialog, I would replace
> _("Do you want to delete it?")
with
> _("Do you want to permanently delete it?")
since I think it would make clear what is going to happen (we use the same phrase when you delete a file via context menu, or on a remote via hotkey)
Comment 8 Git Bot editbugs 2019-12-23 16:30:43 CET
Andre Miranda referenced this bugreport in commit 3d377f91b84cfd01b6526ea733bd4f568faf59ec

When move to trash fails, ask whether to delete files (Bug #15975)

https://git.xfce.org/xfce/thunar/commit?id=3d377f91b84cfd01b6526ea733bd4f568faf59ec
Comment 9 Git Bot editbugs 2019-12-23 16:31:23 CET
Andre Miranda referenced this bugreport in commit faf5f674a3c614763b9dcb91308e413cfbc65dc8

When move to trash fails, ask whether to delete files (Bug #15975)

https://git.xfce.org/xfce/thunar/commit?id=faf5f674a3c614763b9dcb91308e413cfbc65dc8
Comment 10 Andre Miranda editbugs 2019-12-23 16:32:16 CET
Thanks for testing and the message suggestion!

Bug #15975

Reported by:
Manuel Grießmayr
Reported on: 2019-09-20
Last modified on: 2019-12-23

People

Assignee:
Xfce Bug Triage
CC List:
3 users

Version

Attachments

quick fix (4.71 KB, patch)
2019-12-21 19:27 CET , Andre Miranda
no flags

Additional information