Downstream bug report - https://bugzilla.redhat.com/show_bug.cgi?id=1752022 From the report, Description of problem: It happened yesterday, so I think I was editing a keyboard shortcut (changing the URL after a web browser command) and so I set the same shortcut as before. Then a dialog popped-up asking which command I wanted to use, the old or the new, I clicked the new one and... now I'm not quite sure if the settings manager crashed right there or if the window went back to the main window (that is an internal crash anyway as it's supposed to stay in the keyboard shortcuts window). But eventually the GUI crashed and abrt popped-up. This is an operation that usually works, but sometimes Xfce crashes and I feel it's related with having an old computer and doing things quickly. Mostly is Thunar crashing when dealing with thumbnails. Version-Release number of selected component: xfce4-settings-4.14.1-1.fc30 Additional info: reporter: libreport-2.10.1 backtrace_rating: 4 cmdline: xfce4-keyboard-settings --socket-id=58720942 crash_function: is_end executable: /usr/bin/xfce4-keyboard-settings journald_cursor: s=950fb7e409774778901f839c81a04a32;i=119201;b=e494d5f3737d444998da1495c4909ae0;m=13fd7c9b;t=59261cf81f058;x=b706f206af04ba46 kernel: 5.2.13-200.fc30.x86_64 rootdir: / runlevel: N 5 type: CCpp uid: 1000 Truncated backtrace: Thread no. 1 (10 frames) #0 is_end at ../glib/gsequence.c:202 #1 g_sequence_iter_is_end at ../glib/gsequence.c:1405 #2 iter_is_valid at gtkliststore.c:392 #3 gtk_list_store_remove at gtkliststore.c:1203 #4 xfce_keyboard_settings_edit_button_clicked at xfce-keyboard-settings.c:1164 #5 _g_closure_invoke_va at ../gobject/gclosure.c:873 #8 gtk_button_do_release at gtkbutton.c:1845 #10 gtk_real_button_released at gtkbutton.c:1963 #11 _g_closure_invoke_va at ../gobject/gclosure.c:873 #14 multipress_released_cb at gtkbutton.c:666
*** Bug 12933 has been marked as a duplicate of this bug. ***
Created attachment 9563 patch The bug occurs when one uses the Edit button to change the command of an existing key combo. In this case gtk_list_store_remove() was already called by xfce_keyboard_settings_validate_shortcut -> xfce_keyboard_settings_shortcut_removed.
Theo Linkspfeifer referenced this bugreport in commit d5f96a214230a9fd3e0d137cb733f284ba23bfe4 keyboard: Fix crash when editing shortcut (Bug #15958) https://git.xfce.org/xfce/xfce4-settings/commit?id=d5f96a214230a9fd3e0d137cb733f284ba23bfe4
Theo Linkspfeifer referenced this bugreport in commit d279c793c9b43cbfe951e85abb4fddd1a35487a5 keyboard: Fix crash when editing shortcut (Bug #15958) https://git.xfce.org/xfce/xfce4-settings/commit?id=d279c793c9b43cbfe951e85abb4fddd1a35487a5
Patch looks good to me. Applied to master and 4.14 above.