In xfce-4.12 you could set the urgend notification color via bg[SELECTED] and the panel button would blink then in that color when the window is urgend without looking pushed, but in xfce-4.14 not only does the button not have the bg selection color but it just looks like a pushed button when blinking. This should be reverted as the bg selection color is much more visible than a button being pushed also button being pushed/unpushed gives a wrong impression. This should be reverted to the button having the bg selection color again instead of being pushed. Because urgend notifications need to be much more visible than a pushed button!
Ok some further research revealed there is a suggested-action style class which should be set for those urgend window buttons.
Created attachment 9019 Set suggested-action style class instead of blinking. I created a patch setting the suggested-action style class instead of blinking. But probably that blinking function in libxfce4panel should also be fixed to set suggested-action style class instead of setting the button as active. BTW blinking animation could also be achieved via gtk theme CSS animations, either for the suggested-action property or for an individual class defined by Xfce.
I updated the patch to patch the blinking directly, here is my pull request: git request-pull 18dd918f4f58ab0f5869e82a1e0f4bfcdecc99bc https://github.com/Sur3/xfce4-panel.git
Sorry I only see this report/patch now. Setting a class definitely makes more sense that flipping the states. I'm not 100% convinced about suggested-action, I guess I'd have to see it. Would you mind opening a merge request on gitlab.xfce.org for this? https://gitlab.xfce.org/xfce/xfce4-panel/
Created attachment 9829 suggested action blinking patch I tried to record it, as you can hopefully see the default suggested-action color is blue: https://youtu.be/8gIrXsJUEdo I tried to make a merge request but your gitlab says something about "Namespace is not valid" and "Project limit reached" when I try to fork on your gitlab to make a merge request, or is it possible to open a mergerequest without having a project/fork on your gitlab as well? I updated the patch here though to my latest version, hope that helps.
As announced on the mailing list new users don't get full access to gitlab by default because we're afraid of spambots. I've given you access now, so you can create a merge request. The animation and everything seems fine, it looks a little intense, but I guess that was also the case with Gtk2. A few notes about your patch: 1) The indendation and code formatting doesn't match the rest of the file (spaces before brackets, newlines before curly brackets etc) 2) Why did you add the new functions to the header file and export it as new API? 3) Why didn't you just modify xfce_arrow_button_blinking_timeout in place?
Created attachment 9832 Shorter version of the patch Untested, but a shorter version of your approach.
2+3) The Idea of an individual function in the API was to be able to maybe only set suggested action class without the blinking, which means the button would only be in the urgend notification color but would not blink, because the blinking is 1. annoying sometimes 2. as annotated above the blinking could maybe be implemented as CSS via a GTK3 theme.
But as far as I can see the xfce_arrow_button_get_blinking and xfce_arrow_button_set_blinking api calls are only used in tasklist-widget.c. In the earlier version of my patch I directly patched it there instead of modifying the API calls: https://bugzilla.xfce.org/attachment.cgi?id=9019
-- GitLab Migration Automatic Message -- This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/259. Please create an account or use an existing account on one of our supported OAuth providers. If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev