! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Enhancement: Ask before deleting files as default behaviour
Status:
RESOLVED: WONTFIX
Severity:
enhancement

Comments

Description DarkTrick 2019-09-06 10:57:46 CEST
Suggestion:
 Make Thunar ask before really moving a file to trash (as default behaviour, but toggleable).

Reasons:
 1) If this is not implemented:
     - Holding the [del] key "too long" will remove several files (this might be unexpected)
     - unintentionally wrongly selected files might get deleted

 2) Restoring files from trash is a rather tedious task (compared to eg. how it works under windows).
Comment 1 alexxcons editbugs 2019-09-06 12:36:00 CEST
I disagree on this one.
For permanent deletion, ok. But for trash .. cmon, a "trash on accident" does not happen that often and is reversible.

I bet you would disable the extra-dialog yourself after getting annoyed by it several times ;)

> Restoring files from trash is a rather tedious task
IMO that is the actual problem.  I guess #12345 should help to simplify recovery.
Comment 2 DarkTrick 2019-09-07 08:18:14 CEST
> I guess #12345 should help to simplify recovery.
This definitely would help.
Also a undo function would nicely solve the problem.

> For permanent deletion, ok. But for trash .. cmon, a "trash on accident" does not happen that often and is reversible.
Happens often here. I'm always taking a lot of care touching that delete button.

*I think the important point is the "when is it going to work"-standpoint.*
I think it's much faster and easier to create a "as on delete" option for thunar, than to 
- add a special deletion date
- implement an undo-delete function
- do something about the deleting-spree when holding down the delete button.


Another reason for the suggested feature:
(xfce (?) / ubuntu (?) and) Thunar have occasional focus problems. Areas, that are marked as "focussed" are actually not really focussed. So there are situation, where the currently focussed element is not clearly recognizable for the user.
Eg:  a folder and a file seem to be focussed at the same time. Wanting to delete to file removes a whole folder. The lack of "undo" and "sort by deletion date" make it then very difficult to restore a folder you don't even know the name of.
Comment 3 alexxcons editbugs 2019-09-07 12:03:12 CEST
(In reply to DarkTrick from comment #2)
> *I think the important point is the "when is it going to work"-standpoint.*
> I think it's much faster and easier to create a "as on delete" option for
> thunar, than to 
> - add a special deletion date
> - implement an undo-delete function
> - do something about the deleting-spree when holding down the delete button.
I prefer to fix the actual bug, even if it is more work ... workaround tend to hang around forever.

> - implement an undo-delete function
Actually that would be a hell of work. No way.

> - do something about the deleting-spree when holding down the delete button.
Not sure if that is a feature or a bug.

> Another reason for the suggested feature:
> (xfce (?) / ubuntu (?) and) Thunar have occasional focus problems. Areas,
> that are marked as "focussed" are actually not really focussed. So there are
> situation, where the currently focussed element is not clearly recognizable
> for the user.
> Eg:  a folder and a file seem to be focussed at the same time. Wanting to
> delete to file removes a whole folder. The lack of "undo" and "sort by
> deletion date" make it then very difficult to restore a folder you don't
> even know the name of.
That problem only exists for tree-view (Bug #14369), and is already on the 4.16 roadmap: https://wiki.xfce.org/releng/4.16/roadmap/thunar
Comment 4 DarkTrick 2019-09-11 08:03:09 CEST
FYI

> cmon, a "trash on accident" does not happen that often and is reversible
I figured out, why this started to bug me so much. For some single "del" keypresses two key events are executed. Therefore: My system frequently deletes two files, instead of only one.

There is a bug related to iBus, that I cannot artificially recreate on other machines. This bug makes buttons get pressed twice or not at all. 
Unfortunately, since ubuntu 19.04 this twice-pressing happens within the application finder for arrow-presses and *the deletion key in thunar*. 

I know, this would also go into the corner of "fix the real problem".
Comment 5 alexxcons editbugs 2019-09-11 22:48:19 CEST
(In reply to DarkTrick from comment #4)
> There is a bug related to iBus, that I cannot artificially recreate on other
> machines. This bug makes buttons get pressed twice or not at all. 
> Unfortunately, since ubuntu 19.04 this twice-pressing happens within the
> application finder for arrow-presses and *the deletion key in thunar*. 
> 
> I know, this would also go into the corner of "fix the real problem".
True :)  Probably best to open a bug against iBus

Bug #15937

Reported by:
DarkTrick
Reported on: 2019-09-06
Last modified on: 2019-09-11

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Attachments

Additional information