! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar does not implement the "shared thumbnails" feature of thumbnail spec
Status:
RESOLVED: MOVED

Comments

Description Michael Wyraz 2019-09-02 00:10:09 CEST
The freedesktop thumbnail spec described how to store and retreive thumbnails. Thunar impements only part of the spec. The "shared thumbnail folder" part described in  https://specifications.freedesktop.org/thumbnail-spec/latest/x329.html is entirely missing.

To implement the spec fully, the following things needs to be changed:
- thunar needs to check .sh_thumbnails and display thumbnails there before requesting new thumbanils to be created by tumbler
- tubler needs only to create tumbnails if they are not already in .sh_thumbnails
- for remote drive, thumbnails should also be displayed if they are in  .sh_thumbnails, even if thumbanils for remote drives are disabled.

How to test:
- delete ~/.cache/thumbnails
- on a remote drive, create shared thumbnails (e.g. using https://github.com/jesjimher/genthumbs/blob/master/genthumbs.sh).
- on thunar browse the folder with remote thumbnails enabled
- verify that thumbnails are shown
- verify that ~/.cache/thumbnails remains empty.
Comment 1 chrysn 2020-01-10 08:48:47 CET
This might become easier with the patch from <https://gitlab.gnome.org/GNOME/glib/issues/654>. When that is applied, thunar (or the thumbnailing component it uses) may not need to have any particular knowledge of sh_thumbnails, but could simply use the thumbnail provided by gio's thumbnail::path property. Only if that is absent, it'd need to trigger thumbnail creation. (After it created a thumbnail, that property will be present).

Using information from gio would (from my limited understanding of gio/gvfs) have the additional benefit of allowing network backends to advertise available thumbnails in-band in the future (eg. an ssh backend might advertise the thumbnails in the remote ~/.cache/thumbnails, the http backend might do so based on link metadata, and I'd figure gphoto2 could come up with something as well).
Comment 2 Git Bot editbugs 2020-05-26 23:45:39 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/thunar/-/issues/262.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #15913

Reported by:
Michael Wyraz
Reported on: 2019-09-02
Last modified on: 2020-05-26

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Version:
1.6.12

Attachments

Additional information