! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Modest suggestion for icon tooltips in xfdesktop
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Jean-Pierre Demailly 2019-08-29 09:48:35 CEST
Created attachment 8967 
xfdesktop icon tooltip suggestion

When hovering on a file/folder icon on the desktop, only the type, size and last modification time appear. I would suggest to add first the name of the object in the first line of the tooltip.
Rationale :
- the name of the file/folder is usually hidden by the tooltip window
- in case of a long name, the string appears truncated on the desktop. Users may then want to see the full untruncated name, without necessarily entering into editing the icon ; being able to see the full name  just by hovering is an easy solution to these very minor issues.

Please see attached patch. This would require a slight update of the po files (adding "%s\n"  in the  msgid and msgstr in two places, as I have done e.g. for  fr.po ), could be easily done by an ad hoc script
Comment 1 Andre Miranda editbugs 2019-09-01 21:23:01 CEST
Hi, thanks for the suggestion, I agree with the rationale.
With regards the patch, can you please send another one with commit info (git format-patch HEAD^) and without changes to .po files (they are translated on transifex)?
Comment 2 Jean-Pierre Demailly 2019-09-05 22:18:55 CEST
Created attachment 9007 
Patch adding name of file in tooltips, when hovering on xfdesktop icons
Comment 3 Jean-Pierre Demailly 2019-09-05 22:21:23 CEST
Sorry Andre, that's the first time I have to deal with git (beyond just cloning an existing repository), and I didn't understand how to use git-patch. So I just created a new ordinary patch, without touching the po files.
Comment 4 Jean-Pierre Demailly 2019-09-05 22:23:11 CEST
Sorry Andre, that's the first time I have to deal with git (beyond just cloning an existing repository), and I didn't understand how to use git-patch. So I just created a new ordinary patch, without touching the po files.
Comment 5 Git Bot editbugs 2019-09-26 03:22:40 CEST
Jean-Pierre Demailly referenced this bugreport in commit 2074ee97ddf0d95fcc7fde216f8faad246b06025

Show file names in tooltips (Bug #15899)

https://git.xfce.org/xfce/xfdesktop/commit?id=2074ee97ddf0d95fcc7fde216f8faad246b06025
Comment 6 Git Bot editbugs 2019-09-26 03:23:08 CEST
Jean-Pierre Demailly referenced this bugreport in commit ac5da1fab6163c80c0e51e67eb54eff5ef74b39e

Show file names in tooltips (Bug #15899)

https://git.xfce.org/xfce/xfdesktop/commit?id=ac5da1fab6163c80c0e51e67eb54eff5ef74b39e
Comment 7 Andre Miranda editbugs 2019-09-26 03:25:54 CEST
Thanks for the patch, I pushed it with a couple of modifications:
- display_name is already available, no need to g_file_get_basename (which requires free)
- I didn't apply this change to special file icons (home, file system, removable devices...) because it didn't make sense IMO.

Bug #15899

Reported by:
Jean-Pierre Demailly
Reported on: 2019-08-29
Last modified on: 2019-09-26

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Version:
Unspecified

Attachments

Additional information