! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Unchecking the "Switch worspaces using mouse wheel" checkbox has no effect
Status:
RESOLVED: MOVED
Product:
Xfce4-panel
Component:
Workspace Switcher

Comments

Description Guido Falsi 2019-08-25 20:48:03 CEST
As stated in the summary it looks like the switch has no effect.

I don't like the functionality and I'm not using the mouse wheel on the switcher usually. I discovered this by chance, hitting the mouse wheel by mistake while on the switcher. I checked and the checkbox was unchecked in the properties. i also tested enabling and disabling it again.

Looks like a regression in 4.14.
Comment 1 Andre Miranda editbugs 2019-08-25 22:29:04 CEST
Created attachment 8957 
patch

(In reply to Guido Falsi from comment #0)
> Looks like a regression in 4.14.
In Wnck 2.91.90 they introduced a handler for scroll events, which is not possible to disable.

The attached patch overrides that handler with the panel's custom scroll event handler. I don't think that's elegant, but upstream doesn't make it easy and I don't know how to accomplish the same with g_signal_handlers_disconnect_by_*.
Comment 2 Andre Miranda editbugs 2019-08-26 00:17:58 CEST
Created attachment 8958 
correct patch

I have mistakenly attached the wrong patch in comment1.
Comment 3 Guido Falsi 2019-08-26 12:57:27 CEST
(In reply to Andre Miranda from comment #1)
> (In reply to Guido Falsi from comment #0)
> > Looks like a regression in 4.14.
> In Wnck 2.91.90 they introduced a handler for scroll events, which is not
> possible to disable.
> 
> The attached patch overrides that handler with the panel's custom scroll
> event handler. I don't think that's elegant, but upstream doesn't make it
> easy and I don't know how to accomplish the same with
> g_signal_handlers_disconnect_by_*.

I'm sorry to hear that. I mean I agree the fix may be inelegant but it looks necessary.

I can't test the patch right away. But I'll do ASAP and report back.
Comment 4 Andre Miranda editbugs 2019-08-26 19:06:09 CEST
I found this Merge Request from Simon:
https://gitlab.gnome.org/GNOME/libwnck/merge_requests/13/commits

After that gets merged we may try send another one with the scroll mode WNCK_PAGER_SCROLL_DISABLED.
Comment 5 Guido Falsi 2019-08-27 00:22:27 CEST
I tested your patch and works fine.

(In reply to Andre Miranda from comment #4)
> I found this Merge Request from Simon:
> https://gitlab.gnome.org/GNOME/libwnck/merge_requests/13/commits
> 
> After that gets merged we may try send another one with the scroll mode
> WNCK_PAGER_SCROLL_DISABLED.

This is great news for the future! :)
Comment 6 Git Bot editbugs 2020-05-28 02:14:47 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/253.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #15886

Reported by:
Guido Falsi
Reported on: 2019-08-25
Last modified on: 2020-05-28

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Version:
4.14.0

Attachments

patch (2.49 KB, patch)
2019-08-25 22:29 CEST , Andre Miranda
no flags
correct patch (919 bytes, patch)
2019-08-26 00:17 CEST , Andre Miranda
no flags

Additional information