! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfdesktop crashes when inserting a dvd/cd
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Stavros Giannouris 2006-03-19 21:21:35 CET
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; el; rv:1.8.0.1) Gecko/20060218 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; el; rv:1.8.0.1) Gecko/20060218 Firefox/1.5.0.1

Inserting a CD or a DVD in the drive with file icons turned on, xfdesktop crashes

Reproducible: Always

Steps to Reproduce:
1. Enable file & shortcut icons in xfdesktop
2. insert a media into the cd/dvd drive
3.




here's a backtrace

*** glibc detected *** malloc(): memory corruption (fast): 0x0823af0f
***

Program received signal SIGABRT, Aborted.
[Switching to Thread 1086311104 (LWP 23755)]
0xffffe410 in __kernel_vsyscall ()
(gdb) bt
#0  0xffffe410 in __kernel_vsyscall ()
#1  0x407650d1 in raise () from /lib/tls/libc.so.6
#2  0x4076681b in abort () from /lib/tls/libc.so.6
#3  0x4079ad5a in __libc_message () from /lib/tls/libc.so.6
#4  0x407a0bd2 in malloc_printerr () from /lib/tls/libc.so.6
#5  0x407a2049 in _int_malloc () from /lib/tls/libc.so.6
#6  0x407a31cf in malloc () from /lib/tls/libc.so.6
#7  0x407a6df0 in strdup () from /lib/tls/libc.so.6
#8  0x409670da in libhal_get_string_array_from_iter ()
   from /usr/lib/libhal.so.1
#9  0x409674cf in libhal_device_get_all_properties ()
from /usr/lib/libhal.so.1 #10 0x409617fa in libhal_volume_from_udi ()
from /usr/lib/libhal-storage.so.1 #11 0x40195e76 in
thunar_vfs_volume_manager_hal_device_added ()
from /opt/xfce4/lib/libthunar-vfs-1.so.2 #12 0x40967a2c in filter_func
() from /usr/lib/libhal.so.1 #13 0x40995ca8 in dbus_connection_dispatch
() from /usr/lib/libdbus-1.so.2 #14 0x40974e0d in
message_queue_dispatch () from /usr/lib/libdbus-glib-1.so.2 #15
0x406c918c in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#16 0x406cc60b in g_main_context_iterate ()
from /usr/lib/libglib-2.0.so.0 #17 0x406cc967 in g_main_loop_run ()
from /usr/lib/libglib-2.0.so.0 #18 0x40335cf1 in gtk_main ()
from /usr/lib/libgtk-x11-2.0.so.0 #19 0x08053b78 in main (argc=1,
argv=0xbf9c54e4) at main.c:357 (gdb)
Comment 1 Brian J. Tarricone (not reading bugmail) 2006-04-05 21:39:56 CEST
Reporter: please make sure you're running the latest SVN versions of thunar and xfdesktop.

Benny: any thoughts?  Is it possible I freeing something returned from ThunarVfsVolumeManager that I shouldn't be?
Comment 2 Benedikt Meurer editbugs 2006-04-05 21:44:03 CEST
It is reproducible on FreeBSD with a different backend, so it's likely that the problem is in xfdesktop, yes.

#0  0x2812543a in IA__thunar_vfs_path_to_string (path=0x50,
    buffer=0xbfbfdf20 "/mnt/cdrom", bufsize=2048, error=0x0)
    at thunar-vfs-path.c:667
#1  0x28115d6c in thunar_vfs_volume_freebsd_update (user_data=0x82aa000)
    at thunar-vfs-volume-freebsd.c:335
#2  0x28991f28 in g_main_context_wakeup () from /usr/local/lib/libglib-2.0.so.0
#3  0x2898fa7a in g_main_depth () from /usr/local/lib/libglib-2.0.so.0
#4  0x2899091f in g_main_context_dispatch ()
   from /usr/local/lib/libglib-2.0.so.0
#5  0x28990cea in g_main_context_dispatch ()
   from /usr/local/lib/libglib-2.0.so.0
#6  0x289912be in g_main_loop_run () from /usr/local/lib/libglib-2.0.so.0
#7  0x28459a9e in gtk_main () from /usr/X11R6/lib/libgtk-x11-2.0.so.0
#8  0x08053d13 in main ()

I'll have a look at xfdesktop.
Comment 3 Benedikt Meurer editbugs 2006-04-05 22:05:09 CEST
Created attachment 495 
Suggested fix

Yep, you unref'ed the mount point path without holding a reference on it. The patch fixes the hash table handling.
Comment 4 Brian J. Tarricone (not reading bugmail) 2006-04-05 22:15:26 CEST
Thanks Benny, committed.
Comment 5 Brian J. Tarricone (not reading bugmail) 2006-04-10 01:24:48 CEST
*** Bug 1619 has been marked as a duplicate of this bug. ***

Bug #1587

Reported by:
Stavros Giannouris
Reported on: 2006-03-19
Last modified on: 2009-07-14
Duplicates (1):
  • 1619 xfdesktop crashes when ejecting removable media

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
3 users

Version

Attachments

Suggested fix (1.27 KB, patch)
2006-04-05 22:05 CEST , Benedikt Meurer
no flags

Additional information