Created attachment 8936 Desktop vs. Thunar When I mark an item on the desktop, the name of the item is becoming highlighted but the icon remains the same as it was. This is different to how Thunar shows highlighted items: both the icon and the text are changed. In Xfce 4.12 the desktop and Thunar had this behavior. The issue happens on Xubuntu 19.10 as well as Arch. Video attached.
The fallback style is now based on the Greybird theme which does not highlight the icons. https://git.xfce.org/xfce/xfdesktop/commit/?id=a028fb I preferred the look and feel of this variant. Also, it can be changed in any GTK theme by providing the XfdesktopIconView styling class.
Theo, I think for the sake of consistency we should update the fallback style. The tinting code changed during the gtk3 port: https://git.xfce.org/xfce/xfdesktop/commit/?id=db2337d I guess the following styles look good, let know if you agree with them being part of the fallback css. XfdesktopIconView:active { color: @theme_selected_bg_color; } XfdesktopIconView.view .label:active { color: @theme_selected_fg_color; }
I am fine with adding it.
Andre Miranda referenced this bugreport in commit 70c470b089b02da5e344a0a200acb3f66a388364 fallback style: Highlight selected icons (Bug #15866) https://git.xfce.org/xfce/xfdesktop/commit?id=70c470b089b02da5e344a0a200acb3f66a388364
Andre Miranda referenced this bugreport in commit 337c1b7c6a6aa240a28a7cb10f785b190623b24d fallback style: Highlight selected icons (Bug #15866) https://git.xfce.org/xfce/xfdesktop/commit?id=337c1b7c6a6aa240a28a7cb10f785b190623b24d