! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Time out plugin should react to panel "mode," not "orientation"
Status:
RESOLVED: FIXED
Product:
Xfce4-time-out-plugin
Component:
General

Comments

Description Glen Whitney 2019-08-18 00:52:16 CEST
From xfce 4.10, the "orientation" property of a panel has been superseded by the "mode." Hence the time out plugin should react to the latter. In particular, it should only stack the icon above the label in "vertical" mode, not "horizontal" or "deskbar," and it should only set its vertical size to the plugin size in horizontal mode, not vertical or deskbar.

A possible implementation to resolve this issue has been filed as a pull request against the github mirror of xfce-time-out-plugin, accessible at
https://github.com/xfce-mirror/xfce4-time-out-plugin/pull/2
Comment 1 Skunnyk editbugs 2019-08-18 22:31:40 CEST
Created attachment 8913 
Make time out plugin react to panel mode rather than orientation

We use bugzilla for tracking bugs, so I'm attaching your patch here.
Comment 2 Glen Whitney 2019-08-20 00:21:49 CEST
@Skunnyk, thank you. If you could be so kind as to let me know how you generated that patch file, I'd be happy to attach similar patch files to the other xfce plugin issues I have filed recently. Thanks.
Comment 3 Andre Miranda editbugs 2019-08-20 04:25:10 CEST
(In reply to Glen Whitney from comment #2)
> @Skunnyk, thank you. If you could be so kind as to let me know how you
> generated that patch file, I'd be happy to attach similar patch files to the
> other xfce plugin issues I have filed recently. Thanks.
Behold: https://github.com/xfce-mirror/xfce4-time-out-plugin/pull/2.patch

Or from a terminal: git format-patch HEAD~n, where n is the number of commits you made.
Comment 4 Git Bot editbugs 2019-10-04 05:30:01 CEST
Andre Miranda referenced this bugreport in commit 06b07fb086d95f87a890e8cd7e507294c7d96c05

React to panel "mode," not "orientation" (Bug #15840)

https://git.xfce.org/panel-plugins/xfce4-time-out-plugin/commit?id=06b07fb086d95f87a890e8cd7e507294c7d96c05
Comment 5 Andre Miranda editbugs 2019-10-04 05:30:56 CEST
I have updated the patch to the gtk3 port, but I kept the icon stacking up the label for the deskbar mode (which makes more sense IMO). Thanks for the patch!

Bug #15840

Reported by:
Glen Whitney
Reported on: 2019-08-18
Last modified on: 2019-10-04

People

Assignee:
Xfce-Goodies Maintainers
CC List:
2 users

Version

Attachments

Additional information