! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Launcher menu with multiple applications has excessive padding on the left.
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Launcher

Comments

Description jazztickets 2019-08-13 16:04:04 CEST
Created attachment 8875 
screenshot

In the screenshot the red box shows where the new padding is. This is new to 4.14.0.
Comment 1 Git Bot editbugs 2019-08-14 05:30:04 CEST
Andre Miranda referenced this bugreport in commit ae4ed68b248df16fb0fdf625acc785ae73ef24cf

launcher: Avoid excessive left padding on popup menu (Bug #15819)

https://git.xfce.org/xfce/xfce4-panel/commit?id=ae4ed68b248df16fb0fdf625acc785ae73ef24cf
Comment 2 andreas-strasser 2019-12-01 10:16:42 CET
Created attachment 9289 
Screenshot
Comment 3 andreas-strasser 2019-12-01 10:18:15 CET
After this commit the launcher looks ugly if some icons can't be found.
There should be a column for the icons and one for the text, and a placeholder for missing icons.

The attachment shows what i mean.
Comment 4 Andre Miranda editbugs 2019-12-08 22:54:08 CET
Created attachment 9301 
patch

(In reply to andreas-strasser from comment #3)
> After this commit the launcher looks ugly if some icons can't be found.
> There should be a column for the icons and one for the text, and a
> placeholder for missing icons.
> 
> The attachment shows what i mean.

Please let me know if the attached patch solves the problem for you.
Comment 5 andreas-strasser 2019-12-10 14:00:31 CET
Looks better now.
The text is on the right place, but the icons are still missing.

The problem is only if the ~/.config/xfce4/panel/launcher-x/*.desktop files are from xfce-4.12
When i make a new launcher everithing looks fine.
In the new created *.desktop files the icon line of midori is: "Icon=org.midori_browser"
In the old one it is: "Icon=midori"
Comment 6 Andre Miranda editbugs 2019-12-10 17:20:33 CET
Created attachment 9303 
screenshot

"Icon=midori" works for me.
"Icon=midori1" I get the not found icon (see screenshot).
"Icon=" I get the empty placeholder acting as padding.

I think this makes sense, if no icon is specified we get no icon, but if an invalid one is we get the not found icon.
Comment 7 Git Bot editbugs 2019-12-29 14:02:40 CET
Andre Miranda referenced this bugreport in commit bb1d0ac0bef04c754365fb8572145ad0e81aa0a5

Use an empty placeholder icon for launcher (Bug #15819)

https://git.xfce.org/xfce/xfce4-panel/commit?id=bb1d0ac0bef04c754365fb8572145ad0e81aa0a5
Comment 8 Andre Miranda editbugs 2019-12-29 14:03:29 CET
Works well for me, please reopen if there is still room for improvement.

Bug #15819

Reported by:
jazztickets
Reported on: 2019-08-13
Last modified on: 2019-12-29

People

Assignee:
Xfce Bug Triage
CC List:
2 users

Version

Version:
4.14.0

Attachments

screenshot (6.52 KB, image/png)
2019-08-13 16:04 CEST , jazztickets
no flags
Screenshot (169.82 KB, image/png)
2019-12-01 10:16 CET , andreas-strasser
no flags
patch (2.34 KB, patch)
2019-12-08 22:54 CET , Andre Miranda
no flags
screenshot (3.81 KB, image/png)
2019-12-10 17:20 CET , Andre Miranda
no flags

Additional information