! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
FTBFS on NetBSD due to a typo in a macro reference (patch included)
Status:
RESOLVED: FIXED
Product:
Xfce4-cpugraph-plugin
Component:
General

Comments

Description David H. Gutteridge 2019-08-08 00:42:37 CEST
A reference to "CPUSTATE" in panel-plugin/os.c should be "CPUSTATES" for NetBSD. (We've actually had this patched downstream for a while, but apparently it was never fed back to the Xfce project.)

--- panel-plugin/os.c.orig	2019-07-02 23:18:51.000000000 +0000
+++ panel-plugin/os.c
@@ -226,7 +226,7 @@ read_cpu_data (CpuData *data, guint nb_c
     data[0].load = 0;
     for (i = 1; i <= nb_cpu; i++)
     {
-        cp_time1 = cp_time + CPUSTATE * (i - 1);
+        cp_time1 = cp_time + CPUSTATES * (i - 1);
         used = cp_time1[CP_USER] + cp_time1[CP_NICE] + cp_time1[CP_SYS] + cp_time1[CP_INTR];
         total = used + cp_time1[CP_IDLE];

(Probably redundant, but here's the definition: https://nxr.netbsd.org/search?q=&project=src&defs=CPUSTATES&refs=&path=&hist= .)
Comment 1 David H. Gutteridge 2019-08-08 00:48:10 CEST
Created attachment 8855 
Patch
Comment 2 Git Bot editbugs 2019-08-09 02:22:07 CEST
Andre Miranda referenced this bugreport in commit 58f6d62a2ce479b3799a0ec41c831f360583c054

Fix typo breaking build on NetBSD (Bug #15794)

https://git.xfce.org/panel-plugins/xfce4-cpugraph-plugin/commit?id=58f6d62a2ce479b3799a0ec41c831f360583c054
Comment 3 Andre Miranda editbugs 2019-08-09 02:22:33 CEST
Thanks!

Bug #15794

Reported by:
David H. Gutteridge
Reported on: 2019-08-08
Last modified on: 2019-08-09

People

Assignee:
Xfce-Goodies Maintainers
CC List:
1 user

Version

Attachments

Patch (450 bytes, patch)
2019-08-08 00:48 CEST , David H. Gutteridge
no flags

Additional information