Comment 1 Simon Steinbeiss 2019-08-04 20:43:07 CEST

I have reviewed patches 1, 2 and 3 and they look harmless. I'll continue reading and reviewing...

Comment 2 Simon Steinbeiss 2019-09-19 16:17:15 CEST

When reviewing further I stumpled upon something in patch 5. Did you intentionally move the keymap out of the ifdef? (Maybe irrelevant as that ifdef seems to have been removed since then in master)

-  keymap = gdk_keymap_get_default ();
 #endif
+  keymap = gdk_keymap_get_for_display (display);

The rest seems fine - feel free to merge/push!

(even though the fact that the monitor number will always be 0 is disturbing, I wonder if that already has any side effects since it seems to be the case even without your code...)

Comment 3 Git Bot 2019-10-13 20:06:18 CEST

Andre Miranda referenced this bugreport in commit da3c7aef1046829a0979e1606d308cb205305534

Bump gtk to 3.22 (Bug #15781)

https://git.xfce.org/xfce/libxfce4ui/commit?id=da3c7aef1046829a0979e1606d308cb205305534

Comment 4 Git Bot 2019-10-13 20:06:20 CEST

Andre Miranda referenced this bugreport in commit cec6be7f4091a8188b6b3a6c7be65f9309b50926

Ignore what is hard to replace (Bug #15781)

https://git.xfce.org/xfce/libxfce4ui/commit?id=cec6be7f4091a8188b6b3a6c7be65f9309b50926

Comment 5 Git Bot 2019-10-13 20:06:23 CEST

Andre Miranda referenced this bugreport in commit 813575ece727837f5133b460074e0d036de27473

Replace gdk_error_trap_* and gdk_flush (Bug #15781)

https://git.xfce.org/xfce/libxfce4ui/commit?id=813575ece727837f5133b460074e0d036de27473

Comment 6 Git Bot 2019-10-13 20:06:26 CEST

Andre Miranda referenced this bugreport in commit e8756631cae39dd7c3830b44db7af561867550ae

Replace deprecated device functions (Bug #15781)

https://git.xfce.org/xfce/libxfce4ui/commit?id=e8756631cae39dd7c3830b44db7af561867550ae

Comment 7 Git Bot 2019-10-13 20:06:29 CEST

Andre Miranda referenced this bugreport in commit 1f3732957ea8234510c38ffcb763a95e5d6246b2

Replace gdk_keymap_get_default (Bug #15781)

https://git.xfce.org/xfce/libxfce4ui/commit?id=1f3732957ea8234510c38ffcb763a95e5d6246b2

Comment 8 Git Bot 2019-10-13 20:06:32 CEST

Andre Miranda referenced this bugreport in commit 1d6948a30f490ab1949c648567026eca38de9654

Replace gdk_display_get_screen (Bug #15781)

https://git.xfce.org/xfce/libxfce4ui/commit?id=1d6948a30f490ab1949c648567026eca38de9654

Comment 9 Git Bot 2019-10-13 20:06:35 CEST

Andre Miranda referenced this bugreport in commit 4f90f4f09b2fda2971235e46473a1bafbeb956e4

Replace gtk_show_uri (Bug #15781)

https://git.xfce.org/xfce/libxfce4ui/commit?id=4f90f4f09b2fda2971235e46473a1bafbeb956e4

Comment 10 Git Bot 2019-10-13 20:06:38 CEST

Andre Miranda referenced this bugreport in commit 29bd10d8c686ff7de8d42e6f07bdb6c96239c89e

Do not use gdk_screen_get_monitor_at_point (Bug #15781)

https://git.xfce.org/xfce/libxfce4ui/commit?id=29bd10d8c686ff7de8d42e6f07bdb6c96239c89e

Comment 11 Andre Miranda 2019-10-13 20:12:37 CEST

(In reply to Simon Steinbeiss from comment #2)
> When reviewing further I stumpled upon something in patch 5. Did you
> intentionally move the keymap out of the ifdef? (Maybe irrelevant as that
> ifdef seems to have been removed since then in master)
Yes, keymap should be initialized out of the ifdef, this problem was introduced by a commit in the patchset. I have edited it to avoid this follow-up fix. Also, master didn't have that ifdef, it was introduced by these patches. I'm going to apply them to the 4.14 branch, for master I know we're going to drop gtk2 support soon.

Comment 12 Git Bot 2019-10-13 20:20:19 CEST

Andre Miranda referenced this bugreport in commit 215ea0f876230dba6ec971ad3a097df15518ee66

Bump gtk to 3.22 (Bug #15781)

https://git.xfce.org/xfce/libxfce4ui/commit?id=215ea0f876230dba6ec971ad3a097df15518ee66

Comment 13 Git Bot 2019-10-13 20:20:21 CEST

Andre Miranda referenced this bugreport in commit 5707f672283b96264c50be0c1399f88c91790c2f

Ignore what is hard to replace (Bug #15781)

https://git.xfce.org/xfce/libxfce4ui/commit?id=5707f672283b96264c50be0c1399f88c91790c2f

Comment 14 Git Bot 2019-10-13 20:20:25 CEST

Andre Miranda referenced this bugreport in commit 92f6ceca3a95568f7d4c7c6dc442b324e9a75c7b

Replace gdk_error_trap_* and gdk_flush (Bug #15781)

https://git.xfce.org/xfce/libxfce4ui/commit?id=92f6ceca3a95568f7d4c7c6dc442b324e9a75c7b

Comment 15 Git Bot 2019-10-13 20:20:28 CEST

Andre Miranda referenced this bugreport in commit e03dac9647ceca024db766ed4bbdd77ab5f56a5c

Replace deprecated device functions (Bug #15781)

https://git.xfce.org/xfce/libxfce4ui/commit?id=e03dac9647ceca024db766ed4bbdd77ab5f56a5c

Comment 16 Git Bot 2019-10-13 20:20:31 CEST

Andre Miranda referenced this bugreport in commit 136017bd8a841a7cc43d83ea67a4cf1fe689fa2c

Replace gdk_keymap_get_default (Bug #15781)

https://git.xfce.org/xfce/libxfce4ui/commit?id=136017bd8a841a7cc43d83ea67a4cf1fe689fa2c

Comment 17 Git Bot 2019-10-13 20:20:33 CEST

Andre Miranda referenced this bugreport in commit dc49fdd981511308e4c063586919e4b71bf7f854

Replace gdk_display_get_screen (Bug #15781)

https://git.xfce.org/xfce/libxfce4ui/commit?id=dc49fdd981511308e4c063586919e4b71bf7f854

Comment 18 Git Bot 2019-10-13 20:20:36 CEST

Andre Miranda referenced this bugreport in commit 4c0e4e7b59c47a7b533e39f4a8acbb54a907e5f7

Replace gtk_show_uri (Bug #15781)

https://git.xfce.org/xfce/libxfce4ui/commit?id=4c0e4e7b59c47a7b533e39f4a8acbb54a907e5f7

Comment 19 Git Bot 2019-10-13 20:20:39 CEST

Andre Miranda referenced this bugreport in commit dfdaf372461954434e858bc9695b36899e562dbe

Do not use gdk_screen_get_monitor_at_point (Bug #15781)

https://git.xfce.org/xfce/libxfce4ui/commit?id=dfdaf372461954434e858bc9695b36899e562dbe

Comment 20 Skunnyk 2020-04-29 00:22:30 CEST

*** Bug 14090 has been marked as a duplicate of this bug. ***