! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Inhibit power management during playback
Status:
RESOLVED: FIXED

Comments

Description Simon Steinbeiss editbugs 2019-07-26 09:39:49 CEST
In order to prevent things like screen dimming by xfce4-power-manager, Parole needs to not only inhibit the screensaver when playing back videos, but also power management through /org/freedesktop/PowerManagement/Inhibit.

This is related to bug https://bugzilla.xfce.org/show_bug.cgi?id=14687
Comment 1 Simon Steinbeiss editbugs 2019-07-31 22:53:46 CEST
Created attachment 8833 
Patch to inhibit power management in addition to screen saving

I originally pondered to add an additional option for this, in the end I felt it would be a bit overkill. But if you feel we should add a boolean xfconf prop for powermanagement in addition to screensaving that should be a trivial task based on the existing patch.

Please test/review (d-feet helps ;))!
Comment 2 Simon Steinbeiss editbugs 2019-07-31 23:46:51 CEST
Created attachment 8834 
Cleaned up patch

Prevented a warning and fixed a typo in addition.
Comment 3 Git Bot editbugs 2019-08-03 12:43:28 CEST
Simon Steinbeiss referenced this bugreport in commit f32c7080733a3e1b43ab2196039f1a7dee80fc42

Inhibit power management during video playback (Bug #15747)

https://git.xfce.org/apps/parole/commit?id=f32c7080733a3e1b43ab2196039f1a7dee80fc42
Comment 4 Sean Davis editbugs 2019-08-03 12:43:59 CEST
Looks good to me. Thanks for the patch!

Bug #15747

Reported by:
Simon Steinbeiss
Reported on: 2019-07-26
Last modified on: 2019-08-03

People

Assignee:
Simon Steinbeiss
CC List:
2 users

Version

Version:
unspecified

Attachments

Patch to inhibit power management in addition to screen saving (9.41 KB, patch)
2019-07-31 22:53 CEST , Simon Steinbeiss
no flags
Cleaned up patch (9.41 KB, patch)
2019-07-31 23:46 CEST , Simon Steinbeiss
no flags

Additional information