! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
window title bar keeps blinking if visual bell setting is turned off from ano...
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description QDeKIFHFSzq4Uyvj7U 2019-07-20 02:44:50 CEST
If starting multiple xfce4-terminal instances, 
and at least one of them starts blinking (due to `Visual bell` setting being enabled in `Preferences->Advanced->[v] Visual bell`) 
then if disabling `Visual bell` setting from another terminal, the terminal(s) that are still blinking will never stop blinking when they aren't focused.

tested xfce4-terminal 0.8.8git-02ec7e5 (Xfce 4.14pre2)

rough STR:
1. `$ echo 'switch away from this terminal by clicking any other window'; sleep 2; echo -e '\a'; sleep 200;`

(now that ^ terminal blinks)
2. start new terminal(if not having one already), disable Visual bell via `Preferences->Advanced->[ ] Visual bell` in this new terminal
3. focus the terminal in step 1
4. focus any other window
the terminal in step 1 is still blinking its title bar

expected:
that terminal shouldn't be blinking anymore

I'm guessing the code to de-blink is disabled when the Visual bell setting is disabled and this is why this behavior is seen.
Comment 1 Git Bot editbugs 2019-07-21 15:21:01 CEST
Igor referenced this bugreport in commit 5932d24a175f5e2a36b1dc285d090540e719435d

Allow to unset window urgency hint even if "Visual bell" is disabled

https://git.xfce.org/apps/xfce4-terminal/commit?id=5932d24a175f5e2a36b1dc285d090540e719435d
Comment 2 Igor editbugs 2019-07-21 15:22:36 CEST
Hi, thanks for the report!
You're right, there was an excessive check in the code that prevented the window from stopping blinking.
Comment 3 QDeKIFHFSzq4Uyvj7U 2019-07-21 23:28:59 CEST
Thank you for the fix, much appreciated!

Bug #15729

Reported by:
QDeKIFHFSzq4Uyvj7U
Reported on: 2019-07-20
Last modified on: 2019-07-21

People

CC List:
1 user

Version

Attachments

Additional information