! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
quitting with control-Q doesn't stop the process


Description Yves-Alexis Perez editbugs 2019-07-10 22:31:59 CEST
Hi, a Debian user reported that when using Ctrl-Q to quit Parole, the window disappears but the process is still there (it's obvious when starting from a terminal window). Downstream bug is at https://bugs.debian.org/931166 if you want to ask more details.
Comment 1 Andre Miranda editbugs 2019-07-11 02:37:54 CEST
I'm using parole from current git master, ctrl+q finishes the process here (Arch Linux + gtk 3.24.10).
Comment 2 Andre Miranda editbugs 2019-07-11 02:42:56 CEST
Never mind, I can reproduce now (video has to be playing). I get the following message on terminal:

GStreamer-CRITICAL **:
Trying to dispose element player, but it is in PLAYING instead of the NULL state.
You need to explicitly set elements to the NULL state before
dropping the final reference, to allow them to clean up.
This problem may also be caused by a refcounting bug in the
application or some element
Comment 3 Andre Miranda editbugs 2019-07-11 02:55:20 CEST
Created attachment 8755 

The attached diff (can be pushed w/o my authorship) fixes the problem for me, although I don't know if it's the right/best solution.
Comment 4 Git Bot editbugs 2019-07-22 02:56:08 CEST
Sean Davis referenced this bugreport in commit dd98777b771ad5308d6aef6ee22e09f105176455

Fix closing of Parole process with Ctrl-Q (bug #15698)

Comment 5 Sean Davis editbugs 2019-07-22 02:56:38 CEST
Sure enough, that seems to do it. Thanks for the patch Andre!

Bug #15698

Reported by:
Yves-Alexis Perez
Reported on: 2019-07-10
Last modified on: 2019-07-22


Simon Steinbeiss
CC List:
3 users




fix.diff (490 bytes, patch)
2019-07-11 02:55 CEST , Andre Miranda
no flags

Additional information