! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Desktop zoom "nearest" texture filter does not work after version 4.13.1 (patch)
Status:
RESOLVED: MOVED

Comments

Description Juha Aatrokoski 2019-07-03 15:30:43 CEST
Created attachment 8719 
Fix texture filter patch

Between versions 4.13.1 and 4.13.2 the GL_NEAREST filter (used on the deepest levels of desktop zoom) stopped working, and GL_LINEAR was used instead. Looking at the diff between the version and with a bit of trial I found the culprit and the fix (patch attached).

A quick internet search led me to this: https://stackoverflow.com/questions/12363463/when-should-i-set-gl-texture-min-filter-and-gl-texture-mag-filter

If I understand the answer correctly, both GL_TEXTURE_MIN_FILTER and GL_TEXTURE_MAG_FILTER must be specified for either of them to take effect (seems like the settings are added to a "shadow" settings object, from which they are latched to the actual texture only when the whole set is valid/complete).
Comment 1 Olivier Fourdan editbugs 2019-07-03 15:47:14 CEST
Can you please provide a git-format-patch with the common format (description, bug id, what's the problem, how it fixes it and a sign-of-by)?

(check git log to see what I mean by common format)
Comment 2 Juha Aatrokoski 2019-07-04 09:56:07 CEST
Created attachment 8722 
0001-compositor-Fix-GL-texture-filter.patch
Comment 3 Git Bot editbugs 2019-07-05 22:08:03 CEST
Juha Aatrokoski referenced this bugreport in commit 7a92d0329483a6adaac6615ec39172345398951c

compositor: Fix GL texture filter

https://git.xfce.org/xfce/xfwm4/commit?id=7a92d0329483a6adaac6615ec39172345398951c
Comment 4 Git Bot editbugs 2020-05-29 12:27:30 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfwm4/-/issues/337.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #15676

Reported by:
Juha Aatrokoski
Reported on: 2019-07-03
Last modified on: 2020-05-29

People

Assignee:
Olivier Fourdan
CC List:
0 users

Version

Version:
GIT Master

Attachments

Fix texture filter patch (685 bytes, patch)
2019-07-03 15:30 CEST , Juha Aatrokoski
no flags
0001-compositor-Fix-GL-texture-filter.patch (1.33 KB, patch)
2019-07-04 09:56 CEST , Juha Aatrokoski
no flags

Additional information