Created attachment 8702 [PATCH] Toggle the show desktop button when drag a file over there Hi All, This is something that I wanted to do a long time ago. Attached a patch to implement a new behavior to the "show desktop" plugin. The idea is that having many windows open, you can drag a file from thunar, drag it to the plugin to show the desktop, and then drop it on the desktop.. Regards, Matias
Hey, awesome idea - I like the feature! When testing it a bit I noticed that the 1sec may be a bit ample, but alright. 1) But what I really miss is visual feedback of the hover. I think that would help make this a little more intuitive. 2) The button is easily activated again and the state reverted if one hovers too long over the button. I guess that's an issue with the general design of the plugin (that it's a toggle) and not so easily fixable. If you could tackle 1) that'd be awesome, I'm happy to merge it in before 4.14 because I feel the plugin should have always been doing this ;)
Created attachment 8721 [PATCH] Toggle the show desktop button when drag a file over there. V2
Hi Simon, > When testing it a bit I noticed that the 1sec may be a bit ample, but alright. It gave me the same impression, but it is difficult to establish an adequate value.. Now I did it with 500 ms, in line with the tasklist plugin that have a similar behavior. This seems fast, but at least it's consistent.. > 1) But what I really miss is visual feedback of the hover. I think that would help make this a little more intuitive. Done.. However there is some conflict with the CSS of greybird, testing it with adwaita works. > 2) The button is easily activated again and the state reverted if one hovers too long over the button. I guess that's an issue with the general design of the plugin (that it's a toggle) and not so easily fixable. In general I do not like saying this, but it's a feature. haha. GTK emits drag_motion again when you move the mouse over the widget even if you have not come out on it. > If you could tackle 1) that'd be awesome, I'm happy to merge it in before 4.14 because I feel the plugin should have always been doing this ;) Greats, By the way, congratulations for all the work you are doing in this release. ;)
p.s: I want to do something similar with xfce4-places-plugin -that opens the menu, and with the open menu, you can activate a bookmark to launch thunar.- but it's a more complicated patch.
Ok, this looks good! The drag highlight missing in Greybird is a theming bug, I'll try to take care of it. > By the way, congratulations for all the work you are doing in this release. ;) Thanks! Much appreciated. And looking forward to your places-menu patch! :)
Matias De lellis referenced this bugreport in commit 120ed6d766b2ada4beda0d96e69a0e18f629e561 show-desktop: Toggle also when DND-ing (Bug #15654) https://git.xfce.org/xfce/xfce4-panel/commit?id=120ed6d766b2ada4beda0d96e69a0e18f629e561
Just FYI, I fixed the indentation to align with the rest of the code.