Description: Activating the tic-tac-toe hidden functionality crashes the panel Steps to reproduce: 1. Right click on the panel 2. Select “Panel” 3. Select About 4. In the about panel, click “Credits” 5. In the list, select the “Tic-tac-Toe” entry Actual result: Panel crashes Expected result: Err... no crash?
I tried to reproduce this bug, but the panel did not crash.
I'm using panel from current git master, it doesn't crash to me either.
Created attachment 8710 BAcktrace Backtrace of the crash
Please check the code, this is simple case of a “use-after-free” with a possible “double free”. When clicking the “tic-tac-toe” window, the dialog is destroyed in `panel_dialogs_show_about_email_hook()` and reused again in `panel_dialogs_show_about()` (`if (GTK_IS_WIDGET (about_dialog)) gtk_widget_destroy (about_dialog);`)
Created attachment 8711 [PATCH] Avoid use-after-free/double-free with tic-tac-toe Clicking on the easter egg “tic-tac-toe” would crash the panel. Avoid the use-after-free/double-free by not destroying the dialog in the email hook.
Olivier Fourdan referenced this bugreport in commit d04a412c072ee94a29fa14894cf46cfada2c60a2 tic-tac-toe: Avoid use-after-free/double-free (Bug #15649) https://git.xfce.org/xfce/xfce4-panel/commit?id=d04a412c072ee94a29fa14894cf46cfada2c60a2
I still remember in what shape I found tic-tac-toe when picking up the Gtk+3 port of the panel, so I'm happy this is the only bug you found (so far) ;) Thanks a lot for the patch! I hope you don't mind that I adjusted the commit message to fit the panel changelog style.
Created attachment 8752 Updated patch
Oops