Maybe change this string: Select all and only the items that are not currently selected To something like: Select all files but only those not currently selected Select all files but not those currently selected Seems to be a description/tooltips or something for: _Invert Selection There are other strings near by using "files" instead of "items": Select _all Files Select all files in this window Select all files that match a certain pattern
Where this sting is used ? (missing context)
Maybe this helps: https://git.xfce.org/xfce/thunar/tree/thunar/thunar-standard-view.c#n413
Maybe the string is visible in the status bar when hovering the "_Invert Selection" menu item.
I would go with "Select all items but not those currently selected" and rename "files" to "items" in all other descriptions.
Actually I would vote for using "files" over "items", because it is more clear/precise. (Dont think we invert selection for non-file items somewhere) I would go for "Select all files which currently are not selected", but "Select all files but not those currently selected" would as well be fine for me.
(In reply to alexxcons from comment #5) > Actually I would vote for using "files" over "items", because it is more > clear/precise. (Dont think we invert selection for non-file items somewhere) By "items" I also mean folders, not only files. But I don't have any strong preference, as long as "files" or "items" are used consistently, whatever is fine to me.
I read something about everything being a file in UNIX. So maybe a folder is a file with a folder bit set or something but i dont know.
Alexander Schwinn referenced this bugreport in commit c13b4728fe87a05885e7b436a5969a19aa57b202 Improve explanation string for "invert selection" action (Bug #15625) https://git.xfce.org/xfce/thunar/commit?id=c13b4728fe87a05885e7b436a5969a19aa57b202
Heh, funny, I did not even think about a folder, beeing "not a file". That's why I thought "items" would be less precise :P Depends on the POV. Just pushed to master. ( Not to 4.14, since it is on string freeze )