! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfconf tests fail when run before installing xfconf
Status:
RESOLVED: MOVED

Comments

Description Michał Górny 2019-06-17 11:26:07 CEST
Right now, xfconf's tests seem to rely on xfconfd being installed and running. This is wrong because normally 'make check' is run before installing the package in question, in order to verify that there are no regressions. This either causes the wrong version to be tested, or tests to fail entirely (on first install).

While working on it for Gentoo, I've managed to get them running from source directory by doing the following:
1. Installing the D-Bus .service file into location seen by D-Bus daemon (inside overriden XDG_* directory) with xfconfd path set to build tree path,
2. Starting clean D-Bus session daemon instance via dbus-launch,
3. Then running the tests.

I'm going to try to incorporate this into automake.
Comment 1 Michał Górny 2019-06-17 12:07:16 CEST
Created attachment 8641 
0001-Run-tests-inside-isolated-D-Bus-session-s-WIP.patch

Here's what I came up with. Good news is, it mostly works. Bad news is, it has some race conditions that cause tests to fail randomly.

It uses TESTS_ENVIRONMENT to introduce a wrapper that spawns D-Bus session bus for each test. If you have any suggestion how we could run a single D-Bus instance for all of the tests, that would probably help.
Comment 2 Git Bot editbugs 2020-05-25 23:50:24 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfconf/-/issues/5.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #15617

Reported by:
Michał Górny
Reported on: 2019-06-17
Last modified on: 2020-05-25

People

Assignee:
Xfce Bug Triage
CC List:
0 users

Version

Version:
GIT Master

Attachments

Additional information