! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Maybe find another name for "Square icons"
Status:
RESOLVED: MOVED
Product:
Xfce4-panel
Component:
General

Comments

Description scootergrisen 2019-06-13 16:23:51 CEST
I dont understand the "Sq_uare icons" option in panel preferences.
Seems like it having nothing to do with being square.

I dont see the icons being more of less square when "Sq_uare icons" is toggled.

The icons are placed different and the icon size can be different.

Maybe find another name then "Sq_uare icons".
I dont know exactly what the option does but here is what i see:

With "Sq_uare icons" on it seems the icons are limited to 32 pixels. And placed in a grid of multiple rows/columns. The frame around the plugin is not allowed for some reason.
With "Sq_uare icons" off it seems the icons are limited to 64 pixels. And placed on 1 row or columns (depending on the vertical/horizontal mode of the panel).

I also found the string "Square icons" in xfce4-indicator-plugin and xfce4-statusnotifier-plugin which might be the same.
Comment 1 scootergrisen 2019-06-13 16:52:09 CEST
Seems like "Sq_uare icons" means that each icon will take up what is called a row in "Num_ber of rows:".

So maybe the string could be:
One icon per row.
One icon per square.
One icon per panel square.
One icon per panel cubes.

But if you set panel preferences to use 4 rows in vertical panel mode there is 4 rows on the panel. As expected.
But if you change the panel to horizontal mode well then you have 4 columns, not rows.
So maybe rows in "Num_ber of rows:" is incorrect.

Anyway i dont think its a good idea to have all these style settings in each plugin.
I think it would be better to have style settings in the panel preferences so you can set them for all plugin in the same place. Rather then having to go into each plugin preferences and make extra adjustments.

So maybe the solution is to remove such settings, also icon size setting from the plugin and control it from the panel preferences.
Comment 2 Git Bot editbugs 2020-05-28 02:12:11 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/234.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #15601

Reported by:
scootergrisen
Reported on: 2019-06-13
Last modified on: 2020-05-28

People

Assignee:
Xfce Bug Triage
CC List:
0 users

Version

Version:
4.13.5

Attachments

Additional information