I wonder... if i open a file that is not UTF-8 encoded i get a dialog to select encoding... and the dialog is showing a text area. Why not just use the regular Mousepad text area in a tab and then have the encoding selection and buttons on something like a bar. That way you only have to deal with one window and easier to just close it if you want out. Right now if you want out first you have to close the dialog and then close the window.
Created attachment 9888 0001-Do-not-open-an-empty-document-when-encoding-failed.patch Related to that, I don't really understand why an empty document is opened when encoding failed. If the user tries to open a file for which no valid encoding option exists, he don't want to open a new empty document: he will probably want to open his file with a more sophisticated software, or he should. So I think that Mousepad should simply close in this case, with status EXIT_FAILURE. Perhaps this could be done like in the attached patch.
Created attachment 9892 0001-Do-not-open-an-empty-document-when-encoding-failed.patch I forgot the case of an empty files list.
-- GitLab Migration Automatic Message -- This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/mousepad/-/issues/30. Please create an account or use an existing account on one of our supported OAuth providers. If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev